From 53ecdf7db6d900eed614fbb845d7aac6aebfdc75 Mon Sep 17 00:00:00 2001
From: Nowell Strite <nowell@strite.org>
Date: Wed, 22 Feb 2023 17:28:03 -0500
Subject: [PATCH] cherry-pick(#21106): fix(loader): experimentalLoader with
 node@18

There is currently a bug when running `node@18.14.2` when running with
experimentalLoader

```
TypeError: The URL must be of scheme file
  at new NodeError (node:internal/errors:399:5)
  at Object.fileURLToPath (node:internal/url:1492:11)
  at resolve (./node_modules/@playwright/test/lib/experimentalLoader.js:39:48)
  at nextResolve (node:internal/modules/esm/loader:163:22)
  at ESMLoader.resolve (node:internal/modules/esm/loader:838:24)
  at ESMLoader.getModuleJob (node:internal/modules/esm/loader:424:7)
  at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:79:21)
```

This came from my test `vrt.spec.ts` which had a non package import
inside of it

```ts
import fs from "node:fs/promises"
```

The test run failed due to node imports not returning fileUrls when
resolved.

---------

Co-authored-by: Nowell Strite <nstrite@nvidia.com>
---
 .../playwright-test/src/experimentalLoader.ts |  3 +-
 tests/playwright-test/loader.spec.ts          | 29 +++++++++++++++++++
 2 files changed, 31 insertions(+), 1 deletion(-)

diff --git a/packages/playwright-test/src/experimentalLoader.ts b/packages/playwright-test/src/experimentalLoader.ts
index f10daec192..3f7244a335 100644
--- a/packages/playwright-test/src/experimentalLoader.ts
+++ b/packages/playwright-test/src/experimentalLoader.ts
@@ -29,8 +29,9 @@ async function resolve(specifier: string, context: { parentURL?: string }, defau
       specifier = url.pathToFileURL(resolved).toString();
   }
   const result = await defaultResolve(specifier, context, defaultResolve);
-  if (result?.url)
+  if (result?.url && result.url.startsWith('file://'))
     currentFileDepsCollector()?.add(url.fileURLToPath(result.url));
+
   return result;
 }
 
diff --git a/tests/playwright-test/loader.spec.ts b/tests/playwright-test/loader.spec.ts
index 08d359e4ad..883d81d14c 100644
--- a/tests/playwright-test/loader.spec.ts
+++ b/tests/playwright-test/loader.spec.ts
@@ -632,3 +632,32 @@ test('should import export assignment from ts', async ({ runInlineTest }) => {
   expect(result.passed).toBe(1);
   expect(result.exitCode).toBe(0);
 });
+
+test('should support node imports', async ({ runInlineTest, nodeVersion }) => {
+  // We only support experimental esm mode on Node 16+
+  test.skip(nodeVersion.major < 16);
+  const result = await runInlineTest({
+    'playwright.config.ts': 'export default {}',
+    'package.json': JSON.stringify({
+      type: 'module'
+    }),
+    'test.json': 'test data',
+    'utils.mjs': `
+      import fs from "node:fs/promises";
+
+      export async function utilityModuleThatImportsNodeModule() {
+        return await fs.readFile('test.json', 'utf8');
+      }
+    `,
+    'a.test.ts': `
+      import { test, expect } from '@playwright/test';
+      import { utilityModuleThatImportsNodeModule } from './utils.mjs';
+
+      test('pass', async () => {
+        expect(await utilityModuleThatImportsNodeModule()).toBe('test data');
+      });
+    `
+  });
+  expect(result.passed).toBe(1);
+  expect(result.exitCode).toBe(0);
+});