Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore(test): fix tests when using browser path overwrites (#3453)

Browse source
This commit is contained in:
Max Schmitt 2020-08-15 04:34:42 +02:00 committed by GitHub
parent 35fbd588c8
commit 5410c30908
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
test/base.fixture.ts
View file

@ -86,14 +86,19 @@ registerWorkerFixture('httpService', async ({parallelIndex}, test) => {
]);
});
registerWorkerFixture('defaultBrowserOptions', async({}, test) => {
let executablePath = undefined;
const getExecutablePath = () => {
if (browserName === 'chromium' && process.env.CRPATH)
executablePath = process.env.CRPATH;
return process.env.CRPATH;
if (browserName === 'firefox' && process.env.FFPATH)
executablePath = process.env.FFPATH;
return process.env.FFPATH;
if (browserName === 'webkit' && process.env.WKPATH)
executablePath = process.env.WKPATH;
return process.env.WKPATH;
return
}
registerWorkerFixture('defaultBrowserOptions', async({}, test) => {
let executablePath = getExecutablePath();
if (executablePath)
console.error(`Using executable at ${executablePath}`);
await test({
@ -147,7 +152,11 @@ registerFixture('toImpl', async ({playwright}, test) => {
});
registerWorkerFixture('browserType', async ({playwright}, test) => {
await test(playwright[process.env.BROWSER || 'chromium']);
const browserType = playwright[process.env.BROWSER || 'chromium']
const executablePath = getExecutablePath()
if (executablePath)
browserType._executablePath = executablePath
await test(browserType);
});
registerWorkerFixture('browser', async ({browserType, defaultBrowserOptions}, test) => {