Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(test): unflake workers test (#17728)

Browse source
This commit is contained in:
Pavel Feldman 2022-09-30 07:07:20 -08:00 committed by GitHub
parent 0e740f85ea
commit 5424c8c385
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 39 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

48
tests/playwright-test/runner.spec.ts
View file

@ -190,33 +190,63 @@ test('worker interrupt should report errors', async ({ runInlineTest }) => {
test('should not stall when workers are available', async ({ runInlineTest }) => { test('should not stall when workers are available', async ({ runInlineTest }) => {
const result = await runInlineTest({ const result = await runInlineTest({
'a.spec.js': ` 'a.spec.js': `
const { test } = pwt const { test } = pwt;
test('fails-1', async () => { const { writeFile, waitForFile } = require('./utils.js');
test('fails-1', async ({}, testInfo) => {
await waitForFile(testInfo, 'lockA');
console.log('\\n%%fails-1-started'); console.log('\\n%%fails-1-started');
await new Promise(f => setTimeout(f, 2000)); writeFile(testInfo, 'lockB');
console.log('\\n%%fails-1-done'); console.log('\\n%%fails-1-done');
expect(1).toBe(2); expect(1).toBe(2);
}); });
test('passes-1', async () => { test('passes-1', async ({}, testInfo) => {
console.log('\\n%%passes-1'); console.log('\\n%%passes-1');
writeFile(testInfo, 'lockC');
}); });
`, `,
'b.spec.js': ` 'b.spec.js': `
const { test } = pwt const { test } = pwt;
test('passes-2', async () => { const { writeFile, waitForFile } = require('./utils.js');
await new Promise(f => setTimeout(f, 1000)); test('passes-2', async ({}, testInfo) => {
console.log('\\n%%passes-2-started'); console.log('\\n%%passes-2-started');
await new Promise(f => setTimeout(f, 3000)); writeFile(testInfo, 'lockA');
await waitForFile(testInfo, 'lockB');
await waitForFile(testInfo, 'lockC');
console.log('\\n%%passes-2-done'); console.log('\\n%%passes-2-done');
}); });
`, `,
'utils.js': `
const fs = require('fs');
const path = require('path');
function fullName(testInfo, file) {
return path.join(testInfo.config.projects[0].outputDir, file);
}
async function waitForFile(testInfo, file) {
const fn = fullName(testInfo, file);
while (true) {
if (fs.existsSync(fn))
return;
await new Promise(f => setTimeout(f, 100));
}
}
function writeFile(testInfo, file) {
const fn = fullName(testInfo, file);
fs.mkdirSync(path.dirname(fn), { recursive: true });
fs.writeFileSync(fn, '0');
}
module.exports = { writeFile, waitForFile };
`,
}, { workers: 2 }); }, { workers: 2 });
expect(result.exitCode).toBe(1); expect(result.exitCode).toBe(1);
expect(result.passed).toBe(2); expect(result.passed).toBe(2);
expect(result.failed).toBe(1); expect(result.failed).toBe(1);
expect(stripAnsi(result.output).split('\n').filter(line => line.startsWith('%%'))).toEqual([ expect(stripAnsi(result.output).split('\n').filter(line => line.startsWith('%%'))).toEqual([
'%%fails-1-started',
'%%passes-2-started', '%%passes-2-started',
'%%fails-1-started',
'%%fails-1-done', '%%fails-1-done',
'%%passes-1', '%%passes-1',
'%%passes-2-done', '%%passes-2-done',