Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(screencast): repeat previous frame instead of current (#3890)

Browse source
This commit is contained in:
Yury Semikhatsky 2020-09-15 15:21:50 -07:00 committed by GitHub
parent 592bae1cea
commit 5507553173
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/server/chromium/videoRecorder.ts
View file

@ -95,19 +95,25 @@ export class VideoRecorder {
assert(this._process); assert(this._process);
if (!this._isRunning()) if (!this._isRunning())
return; return;
const duration = this._lastFrameTimestamp ? Math.max(1, Math.round(25 * (timestamp - this._lastFrameTimestamp))) : 1; const repeatCount = this._lastFrameTimestamp ? Math.max(1, Math.round(25 * (timestamp - this._lastFrameTimestamp))) : 1;
this._progress.log(`writing ${duration} frame(s)`); this._progress.log(`writing ${repeatCount} frame(s)`);
this._lastWritePromise = this._flushLastFrame(repeatCount).catch(e => this._progress.log('Error while writing frame: ' + e));
this._lastFrameBuffer = frame; this._lastFrameBuffer = frame;
this._lastFrameTimestamp = timestamp; this._lastFrameTimestamp = timestamp;
this._lastWriteTimestamp = Date.now(); this._lastWriteTimestamp = Date.now();
}
private async _flushLastFrame(repeatCount: number): Promise<void> {
assert(this._process);
const frame = this._lastFrameBuffer;
if (!frame)
return;
const previousWrites = this._lastWritePromise; const previousWrites = this._lastWritePromise;
let finishedWriting: () => void; let finishedWriting: () => void;
this._lastWritePromise = new Promise(fulfill => finishedWriting = fulfill); const writePromise = new Promise<void>(fulfill => finishedWriting = fulfill);
const writePromise = this._lastWritePromise;
await previousWrites; await previousWrites;
for (let i = 0; i < duration; i++) { for (let i = 0; i < repeatCount; i++) {
const callFinish = i === (duration - 1); const callFinish = i === (repeatCount - 1);
this._process.stdin.write(frame, (error: Error | null | undefined) => { this._process.stdin.write(frame, (error: Error | null | undefined) => {
if (error) if (error)
this._progress.log(`ffmpeg failed to write: ${error}`); this._progress.log(`ffmpeg failed to write: ${error}`);