Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(firefox): fire "requestfailed" event on network errors (#1817)

Browse source
This commit is contained in:
Yury Semikhatsky 2020-04-16 13:35:16 -07:00 committed by GitHub
parent f5942295d4
commit 55c01da005
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
package.json
View file

@ -9,7 +9,7 @@
"main": "index.js", "main": "index.js",
"playwright": { "playwright": {
"chromium_revision": "759546", "chromium_revision": "759546",
"firefox_revision": "1082", "firefox_revision": "1083",
"webkit_revision": "1197" "webkit_revision": "1197"
}, },
"scripts": { "scripts": {

10
test/network.spec.js
View file

@ -241,10 +241,10 @@ describe('Network Events', function() {
expect(responses[0].request()).toBeTruthy(); expect(responses[0].request()).toBeTruthy();
}); });
it.fail(FFOX)('Page.Events.RequestFailed', async({page, server}) => { it('Page.Events.RequestFailed', async({page, server}) => {
server.setRoute('/one-style.css', (req, res) => { server.setRoute('/one-style.css', (req, res) => {
req.socket.write('deadbeef'); res.setHeader('Content-Type', 'text/css');
req.socket.end(); res.socket.destroy();
}); });
const failedRequests = []; const failedRequests = [];
page.on('requestfailed', request => failedRequests.push(request)); page.on('requestfailed', request => failedRequests.push(request));
@ -254,7 +254,7 @@ describe('Network Events', function() {
expect(await failedRequests[0].response()).toBe(null); expect(await failedRequests[0].response()).toBe(null);
expect(failedRequests[0].resourceType()).toBe('stylesheet'); expect(failedRequests[0].resourceType()).toBe('stylesheet');
if (CHROMIUM) { if (CHROMIUM) {
expect(failedRequests[0].failure().errorText).toBe('net::ERR_INVALID_HTTP_RESPONSE'); expect(failedRequests[0].failure().errorText).toBe('net::ERR_EMPTY_RESPONSE');
} else if (WEBKIT) { } else if (WEBKIT) {
if (MAC) if (MAC)
expect(failedRequests[0].failure().errorText).toBe('The network connection was lost.'); expect(failedRequests[0].failure().errorText).toBe('The network connection was lost.');
@ -263,7 +263,7 @@ describe('Network Events', function() {
else else
expect(failedRequests[0].failure().errorText).toBe('Message Corrupt'); expect(failedRequests[0].failure().errorText).toBe('Message Corrupt');
} else { } else {
expect(failedRequests[0].failure().errorText).toBe('NS_ERROR_FAILURE'); expect(failedRequests[0].failure().errorText).toBe('NS_ERROR_NET_RESET');
} }
expect(failedRequests[0].frame()).toBeTruthy(); expect(failedRequests[0].frame()).toBeTruthy();
}); });