diff --git a/packages/playwright/types/test.d.ts b/packages/playwright/types/test.d.ts index 2cf21f7350..21bd59af5d 100644 --- a/packages/playwright/types/test.d.ts +++ b/packages/playwright/types/test.d.ts @@ -1825,10 +1825,8 @@ type TestDetailsAnnotation = { description?: string; }; -type TestDetailsTag = `@${string}`; - export type TestDetails = { - tag?: TestDetailsTag | TestDetailsTag[]; + tag?: string | string[]; annotation?: TestDetailsAnnotation | TestDetailsAnnotation[]; } diff --git a/tests/playwright-test/test-tag.spec.ts b/tests/playwright-test/test-tag.spec.ts index 0587cfe7a8..9487e31ea3 100644 --- a/tests/playwright-test/test-tag.spec.ts +++ b/tests/playwright-test/test-tag.spec.ts @@ -147,18 +147,6 @@ test('should enforce @ symbol', async ({ runInlineTest }) => { expect(result.output).toContain(`Error: Tag must start with "@" symbol, got "foo" instead.`); }); -test('types should enforce @ symbol', async ({ runTSC }) => { - const result = await runTSC({ - 'stdio.spec.ts': ` - import { test, expect } from '@playwright/test'; - test('test1', { tag: 'foo' }, () => { - }); - ` - }); - expect(result.exitCode).toBe(2); - expect(result.output).toContain('error TS2322: Type \'"foo"\' is not assignable to type \'`@${string}` | `@${string}`[] | undefined'); -}); - test('should be included in testInfo', async ({ runInlineTest }, testInfo) => { const result = await runInlineTest({ 'a.test.ts': ` diff --git a/utils/generate_types/overrides-test.d.ts b/utils/generate_types/overrides-test.d.ts index a5d6eeb0b9..8494671c76 100644 --- a/utils/generate_types/overrides-test.d.ts +++ b/utils/generate_types/overrides-test.d.ts @@ -70,10 +70,8 @@ type TestDetailsAnnotation = { description?: string; }; -type TestDetailsTag = `@${string}`; - export type TestDetails = { - tag?: TestDetailsTag | TestDetailsTag[]; + tag?: string | string[]; annotation?: TestDetailsAnnotation | TestDetailsAnnotation[]; }