Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test(navigation): fix flaky networkidle tests (#1058)

Browse source 
The network idle tests were waiting for requests to appear on the server, but not for playwright to be notified of the request via protocol. They also assumed performance.now would match up with setTimeout times.
This commit is contained in:
Joel Einbinder 2020-02-19 14:26:02 -08:00 committed by GitHub
parent 84ee297c4b
commit 568c6cbb54
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 28 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

41
test/navigation.spec.js
View file

@ -16,7 +16,6 @@
*/ */
const utils = require('./utils'); const utils = require('./utils');
const { performance } = require('perf_hooks');
/** /**
* @type {PageTestSuite} * @type {PageTestSuite}
@ -396,29 +395,39 @@ module.exports.describe = function({testRunner, expect, playwright, MAC, WIN, FF
expect(response.status()).toBe(200); expect(response.status()).toBe(200);
}); });
/**
* @param {import('../src/frames').Frame} frame
* @param {TestServer} server
* @param {'networkidle0'|'networkidle2'} signal
* @param {() => Promise<void>} action
* @param {boolean} isSetContent
*/
async function networkIdleTest(frame, server, signal, action, isSetContent) { async function networkIdleTest(frame, server, signal, action, isSetContent) {
let lastResponseFinished;
const finishResponse = response => { const finishResponse = response => {
lastResponseFinished = performance.now();
response.statusCode = 404; response.statusCode = 404;
response.end(`File not found`); response.end(`File not found`);
}; };
const waitForRequest = suffix => {
return Promise.all([
server.waitForRequest(suffix),
frame._page.waitForRequest(server.PREFIX + suffix),
])
}
let responses = {}; let responses = {};
// Hold on to a bunch of requests without answering. // Hold on to a bunch of requests without answering.
server.setRoute('/fetch-request-a.js', (req, res) => responses.a = res); server.setRoute('/fetch-request-a.js', (req, res) => responses.a = res);
server.setRoute('/fetch-request-b.js', (req, res) => responses.b = res); server.setRoute('/fetch-request-b.js', (req, res) => responses.b = res);
server.setRoute('/fetch-request-c.js', (req, res) => responses.c = res); server.setRoute('/fetch-request-c.js', (req, res) => responses.c = res);
const initialFetchResourcesRequested = Promise.all([ const initialFetchResourcesRequested = Promise.all([
server.waitForRequest('/fetch-request-a.js'), waitForRequest('/fetch-request-a.js'),
server.waitForRequest('/fetch-request-b.js'), waitForRequest('/fetch-request-b.js'),
server.waitForRequest('/fetch-request-c.js'), waitForRequest('/fetch-request-c.js')
]); ]);
let secondFetchResourceRequested; let secondFetchResourceRequested;
if (signal === 'networkidle0') { if (signal === 'networkidle0') {
server.setRoute('/fetch-request-d.js', (req, res) => responses.d = res); server.setRoute('/fetch-request-d.js', (req, res) => responses.d = res);
secondFetchResourceRequested = server.waitForRequest('/fetch-request-d.js'); secondFetchResourceRequested = waitForRequest('/fetch-request-d.js');
} }
const waitForLoadPromise = isSetContent ? Promise.resolve() : frame.waitForNavigation({ waitUntil: 'load' }); const waitForLoadPromise = isSetContent ? Promise.resolve() : frame.waitForNavigation({ waitUntil: 'load' });
@ -442,10 +451,11 @@ module.exports.describe = function({testRunner, expect, playwright, MAC, WIN, FF
expect(responses.a).toBeTruthy(); expect(responses.a).toBeTruthy();
expect(responses.b).toBeTruthy(); expect(responses.b).toBeTruthy();
expect(responses.c).toBeTruthy(); expect(responses.c).toBeTruthy();
// Finishing first response should leave 2 requests alive and trigger networkidle2. let timer;
finishResponse(responses.a); let timerTriggered = false;
if (signal === 'networkidle0') { if (signal === 'networkidle0') {
// Finishing first response should leave 2 requests alive and trigger networkidle2.
finishResponse(responses.a);
// Finishing two more responses should trigger the second round. // Finishing two more responses should trigger the second round.
finishResponse(responses.b); finishResponse(responses.b);
finishResponse(responses.c); finishResponse(responses.c);
@ -454,11 +464,16 @@ module.exports.describe = function({testRunner, expect, playwright, MAC, WIN, FF
await secondFetchResourceRequested; await secondFetchResourceRequested;
expect(actionFinished).toBe(false); expect(actionFinished).toBe(false);
// Finishing the last response should trigger networkidle0. // Finishing the last response should trigger networkidle0.
timer = setTimeout(() => timerTriggered = true, 500);
finishResponse(responses.d); finishResponse(responses.d);
} else {
timer = setTimeout(() => timerTriggered = true, 500);
// Finishing first response should leave 2 requests alive and trigger networkidle2.
finishResponse(responses.a);
} }
const response = await actionPromise; const response = await actionPromise;
expect(performance.now() - lastResponseFinished).not.toBeLessThan(450); clearTimeout(timer);
expect(timerTriggered).toBe(true);
if (!isSetContent) if (!isSetContent)
expect(response.ok()).toBe(true); expect(response.ok()).toBe(true);