From 5711c8e43af58e4762ca6437a5379a6a48712d7a Mon Sep 17 00:00:00 2001 From: Henrik Skupin Date: Mon, 20 Jan 2025 22:37:38 +0100 Subject: [PATCH] chore(bidi): Fix launcher tests for Firefox With the automatic HTTP to HTTPS upgrade the HTTP proxy as defined via "firefoxUserPrefs" will not be used. Instead directly use the HTTPS site and proxy settings to workaround this feature. --- tests/library/firefox/launcher.spec.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/library/firefox/launcher.spec.ts b/tests/library/firefox/launcher.spec.ts index 294d53643c..0dac82ee51 100644 --- a/tests/library/firefox/launcher.spec.ts +++ b/tests/library/firefox/launcher.spec.ts @@ -21,12 +21,12 @@ it('should pass firefox user preferences', async ({ browserType, mode }) => { const browser = await browserType.launch({ firefoxUserPrefs: { 'network.proxy.type': 1, - 'network.proxy.http': '127.0.0.1', - 'network.proxy.http_port': 3333, + 'network.proxy.ssl': '127.0.0.1', + 'network.proxy.ssl_port': 3333, } }); const page = await browser.newPage(); - const error = await page.goto('http://example.com').catch(e => e); + const error = await page.goto('https://example.com').catch(e => e); expect(error.message).toContain('NS_ERROR_PROXY_CONNECTION_REFUSED'); await browser.close(); }); @@ -36,10 +36,10 @@ it('should pass firefox user preferences in persistent', async ({ mode, launchPe const { page } = await launchPersistent({ firefoxUserPrefs: { 'network.proxy.type': 1, - 'network.proxy.http': '127.0.0.1', - 'network.proxy.http_port': 3333, + 'network.proxy.ssl': '127.0.0.1', + 'network.proxy.ssl_port': 3333, } }); - const error = await page.goto('http://example.com').catch(e => e); + const error = await page.goto('https://example.com').catch(e => e); expect(error.message).toContain('NS_ERROR_PROXY_CONNECTION_REFUSED'); });