Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: tree gardening (#28676)

Browse source 
Looks like massaging the signals test in
8ab0660d1b (diff-f9d332d27364a8a58e52f5d7ffc180df7581589565b62186757b21839aabf889)
didn't make it fully green.

As of today it fails on Darwin 13 which is version 22, so we should not
run into the first if.
This commit is contained in:
Max Schmitt 2023-12-15 17:39:31 -08:00 committed by GitHub
parent 54e2ecc45b
commit 576b3406e3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tests/library/signals.spec.ts
View file

@ -63,7 +63,7 @@ test.describe('signals', () => {
const remoteServer = await startRemoteServer('launchServer', { url: server.EMPTY_PAGE }); const remoteServer = await startRemoteServer('launchServer', { url: server.EMPTY_PAGE });
const pid = await remoteServer.out('pid'); const pid = await remoteServer.out('pid');
process.kill(-pid, 'SIGKILL'); process.kill(-pid, 'SIGKILL');
if (isMac && browserName === 'webkit' && parseInt(os.release(), 10) >= 22 && os.arch() === 'arm64') { if (isMac && browserName === 'webkit' && parseInt(os.release(), 10) > 22 && os.arch() === 'arm64') {
// WebKit on newer macOS exits differently. // WebKit on newer macOS exits differently.
expect(await remoteServer.out('exitCode')).toBe('137'); expect(await remoteServer.out('exitCode')).toBe('137');
expect(await remoteServer.out('signal')).toBe('null'); expect(await remoteServer.out('signal')).toBe('null');

3
tests/page/page-screenshot.spec.ts
View file

@ -857,8 +857,9 @@ it.describe('page screenshot animations', () => {
]); ]);
}); });
it('should wait for fonts to load', async ({ page, server, isWindows, browserName, isLinux }) => { it('should wait for fonts to load', async ({ page, server, isWindows, isAndroid }) => {
it.fixme(isWindows, 'This requires a windows-specific test expectations. https://github.com/microsoft/playwright/issues/12707'); it.fixme(isWindows, 'This requires a windows-specific test expectations. https://github.com/microsoft/playwright/issues/12707');
it.skip(isAndroid, 'Different viewport');
await page.setViewportSize({ width: 500, height: 500 }); await page.setViewportSize({ width: 500, height: 500 });
const fontRequestPromise = new Promise<any>(resolve => { const fontRequestPromise = new Promise<any>(resolve => {
// Stall font loading. // Stall font loading.