diff --git a/packages/trace-viewer/src/ui/settingsToolbarButton.tsx b/packages/trace-viewer/src/ui/settingsToolbarButton.tsx index cbb0284ec9..647f593bf5 100644 --- a/packages/trace-viewer/src/ui/settingsToolbarButton.tsx +++ b/packages/trace-viewer/src/ui/settingsToolbarButton.tsx @@ -33,7 +33,6 @@ export const SettingsToolbarButton: React.FC<{}> = () => { onClick={() => setOpen(current => !current)} /> = () => { verticalOffset={8} requestClose={() => setOpen(false)} anchor={hostingRef} + dataTestId='settings-toolbar-dialog' > diff --git a/packages/trace-viewer/src/ui/shared/dialog.tsx b/packages/trace-viewer/src/ui/shared/dialog.tsx index 6df624a97d..23177055af 100644 --- a/packages/trace-viewer/src/ui/shared/dialog.tsx +++ b/packages/trace-viewer/src/ui/shared/dialog.tsx @@ -24,6 +24,7 @@ export interface DialogProps { verticalOffset?: number; requestClose?: () => void; anchor?: React.RefObject; + dataTestId?: string; } export const Dialog: React.FC> = ({ @@ -34,6 +35,7 @@ export const Dialog: React.FC> = ({ verticalOffset, requestClose, anchor, + dataTestId, children, }) => { const dialogRef = React.useRef(null); @@ -96,7 +98,7 @@ export const Dialog: React.FC> = ({ return ( open && ( - + {children} ) diff --git a/tests/config/traceViewerFixtures.ts b/tests/config/traceViewerFixtures.ts index c6622442cf..e3947ff092 100644 --- a/tests/config/traceViewerFixtures.ts +++ b/tests/config/traceViewerFixtures.ts @@ -68,7 +68,7 @@ class TraceViewerPage { this.metadataTab = page.getByTestId('metadata-view'); this.sourceCodeTab = page.getByTestId('source-code'); - this.settingsDialog = page.locator('.settings-toolbar-dialog'); + this.settingsDialog = page.getByTestId('settings-toolbar-dialog'); this.darkModeSetting = page.locator('.setting').getByText('Dark mode'); this.displayCanvasContentSetting = page.locator('.setting').getByText('Display canvas content'); } diff --git a/tests/library/trace-viewer.spec.ts b/tests/library/trace-viewer.spec.ts index 953b69117a..59441935cf 100644 --- a/tests/library/trace-viewer.spec.ts +++ b/tests/library/trace-viewer.spec.ts @@ -1641,7 +1641,7 @@ test('should toggle canvas rendering', async ({ runAndTrace, page }) => { await page.goto(`data:text/html,
Hello world
`); }); - let snapshotRequestPromise = traceViewer.page.waitForRequest(request => request.url().includes('/snapshot/'), { timeout: 2000 }); + let snapshotRequestPromise = traceViewer.page.waitForRequest(request => request.url().includes('/snapshot/')); // Click on the action with a canvas snapshot await traceViewer.selectAction('goto', 0); @@ -1659,7 +1659,7 @@ test('should toggle canvas rendering', async ({ runAndTrace, page }) => { // Deselect canvas await traceViewer.selectAction('goto', 1); - snapshotRequestPromise = traceViewer.page.waitForRequest(request => request.url().includes('/snapshot/'), { timeout: 2000 }); + snapshotRequestPromise = traceViewer.page.waitForRequest(request => request.url().includes('/snapshot/')); // Select canvas again await traceViewer.selectAction('goto', 0);