Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(best-practices): delete dublicate sentence (#20885)

Browse source
This commit is contained in:
IlinAlekseyS 2023-02-15 22:03:56 +03:00 committed by GitHub
parent 4feb7c9e3b
commit 5899348936
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
docs/src/best-practices-js.md
View file

@ -140,7 +140,7 @@ Assertions are a way to verify that the expected result and the actual result ma
#### Don't use manual assertions #### Don't use manual assertions
Don't use manual assertions that are not awaiting the expect. In the code below the await is inside the expect rather than before it. When using assertions such as `isVisible()` the test wont wait a single second, it will just check the locator is there and return immediately. Use web first assertions such as `toBeVisible()` instead. Don't use manual assertions that are not awaiting the expect. In the code below the await is inside the expect rather than before it. When using assertions such as `isVisible()` the test wont wait a single second, it will just check the locator is there and return immediately.
```js ```js
👎 expect(await page.getByText('welcome').isVisible()).toBe(true); 👎 expect(await page.getByText('welcome').isVisible()).toBe(true);