From 5953472899d47950a18c39d9031640293330d156 Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Mon, 13 Sep 2021 17:01:35 +0200 Subject: [PATCH] devops: fix --full command in FF which installs deps (#8878) Broken since https://github.com/microsoft/playwright/pull/8049 Previously when doing `build.sh --full` it was installing deps + building. Currently when passing `--full` it does not install the deps before, since it tries to compile before. --- browser_patches/firefox-beta/build.sh | 3 ++- browser_patches/firefox/build.sh | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/browser_patches/firefox-beta/build.sh b/browser_patches/firefox-beta/build.sh index 849d08615e..3900a95b77 100755 --- a/browser_patches/firefox-beta/build.sh +++ b/browser_patches/firefox-beta/build.sh @@ -102,7 +102,6 @@ if [[ $1 != "--juggler" ]]; then echo "-- Using cbindgen v${CBINDGEN_VERSION}" cargo install cbindgen --version "${CBINDGEN_VERSION}" fi - ./mach build fi if [[ $1 == "--full" || $2 == "--full" ]]; then @@ -121,6 +120,8 @@ fi if [[ $1 == "--juggler" ]]; then ./mach build faster +else + ./mach build fi if [[ "$(uname)" == "Darwin" ]]; then diff --git a/browser_patches/firefox/build.sh b/browser_patches/firefox/build.sh index 849d08615e..3900a95b77 100755 --- a/browser_patches/firefox/build.sh +++ b/browser_patches/firefox/build.sh @@ -102,7 +102,6 @@ if [[ $1 != "--juggler" ]]; then echo "-- Using cbindgen v${CBINDGEN_VERSION}" cargo install cbindgen --version "${CBINDGEN_VERSION}" fi - ./mach build fi if [[ $1 == "--full" || $2 == "--full" ]]; then @@ -121,6 +120,8 @@ fi if [[ $1 == "--juggler" ]]; then ./mach build faster +else + ./mach build fi if [[ "$(uname)" == "Darwin" ]]; then