Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

cherry-pick(#31356): fix(clock): throw for invalid date

Browse source 
Fixes https://github.com/microsoft/playwright/issues/31354
This commit is contained in:
Max Schmitt 2024-06-19 09:26:47 +02:00
parent 245179103e
commit 599d074f71
3 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/playwright-core/src/client/clock.ts
View file

@ -58,6 +58,8 @@ function parseTime(time: string | number | Date): { timeNumber?: number, timeStr
return { timeNumber: time }; return { timeNumber: time };
if (typeof time === 'string') if (typeof time === 'string')
return { timeString: time }; return { timeString: time };
if (!isFinite(time.getTime()))
throw new Error(`Invalid date: ${time}`);
return { timeNumber: time.getTime() }; return { timeNumber: time.getTime() };
} }

5
packages/playwright-core/src/server/clock.ts
View file

@ -148,5 +148,8 @@ function parseTime(epoch: string | number | undefined): number {
return 0; return 0;
if (typeof epoch === 'number') if (typeof epoch === 'number')
return epoch; return epoch;
return new Date(epoch).getTime(); const parsed = new Date(epoch);
if (!isFinite(parsed.getTime()))
throw new Error(`Invalid date: ${epoch}`);
return parsed.getTime();
} }

5
tests/page/page-clock.spec.ts
View file

@ -245,6 +245,11 @@ it.describe('stubTimers', () => {
expect(await page.evaluate(() => Date.now())).toBe(1400); expect(await page.evaluate(() => Date.now())).toBe(1400);
}); });
it('should throw for invalid date', async ({ page }) => {
await expect(page.clock.setSystemTime(new Date('invalid'))).rejects.toThrow('Invalid date: Invalid Date');
await expect(page.clock.setSystemTime('invalid')).rejects.toThrow('clock.setSystemTime: Invalid date: invalid');
});
it('replaces global setTimeout', async ({ page, calls }) => { it('replaces global setTimeout', async ({ page, calls }) => {
await page.evaluate(async () => { await page.evaluate(async () => {
setTimeout(window.stub, 1000); setTimeout(window.stub, 1000);