From 59fa2cba90e9ff195c7ea12a7d85abbf68d5c2f5 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Thu, 26 Mar 2020 18:14:38 -0700 Subject: [PATCH] test(firefox): enable locale tests (#1562) --- package.json | 2 +- test/emulation.spec.js | 4 ++-- test/workers.spec.js | 11 +++++++++++ 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index fe2e149794..fec84f6081 100644 --- a/package.json +++ b/package.json @@ -9,7 +9,7 @@ "main": "index.js", "playwright": { "chromium_revision": "751710", - "firefox_revision": "1059", + "firefox_revision": "1061", "webkit_revision": "1182" }, "scripts": { diff --git a/test/emulation.spec.js b/test/emulation.spec.js index eeaf53035e..d796ebdd2c 100644 --- a/test/emulation.spec.js +++ b/test/emulation.spec.js @@ -322,7 +322,7 @@ module.exports.describe = function({testRunner, expect, playwright, headless, FF expect(await page.evaluate(() => navigator.language)).toBe('fr-CH'); await context.close(); }); - it.fail(FFOX)('should format number', async({browser, server}) => { + it('should format number', async({browser, server}) => { { const context = await browser.newContext({ locale: 'en-US' }); const page = await context.newPage(); @@ -356,7 +356,7 @@ module.exports.describe = function({testRunner, expect, playwright, headless, FF await context.close(); } }); - it.fail(FFOX)('should format number in popups', async({browser, server}) => { + it('should format number in popups', async({browser, server}) => { const context = await browser.newContext({ locale: 'fr-CH' }); const page = await context.newPage(); await page.goto(server.EMPTY_PAGE); diff --git a/test/workers.spec.js b/test/workers.spec.js index 4a74d357b3..551c5cae4b 100644 --- a/test/workers.spec.js +++ b/test/workers.spec.js @@ -131,5 +131,16 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT, expect(response.request()).toBe(request); expect(response.ok()).toBe(true); }); + it('should format number using context locale', async({browser, server}) => { + const context = await browser.newContext({ locale: 'ru-RU' }); + const page = await context.newPage(); + await page.goto(server.EMPTY_PAGE); + const [worker] = await Promise.all([ + page.waitForEvent('worker'), + page.evaluate(() => new Worker(URL.createObjectURL(new Blob(['console.log(1)'], {type: 'application/javascript'})))), + ]); + expect(await worker.evaluate(() => (10000.20).toLocaleString())).toBe('10\u00A0000,2'); + await context.close(); + }); }); };