diff --git a/src/server/webkit/wkInterceptableRequest.ts b/src/server/webkit/wkInterceptableRequest.ts index 7283714be7..8aff250bb2 100644 --- a/src/server/webkit/wkInterceptableRequest.ts +++ b/src/server/webkit/wkInterceptableRequest.ts @@ -89,7 +89,7 @@ export class WKInterceptableRequest { requestStart: timingPayload ? wkMillisToRoundishMillis(timingPayload.requestStart) : -1, responseStart: timingPayload ? wkMillisToRoundishMillis(timingPayload.responseStart) : -1, }; - const setCookieSeparator = process.platform === 'linux' ? '\n' : ','; + const setCookieSeparator = process.platform === 'darwin' ? ',' : '\n'; return new network.Response(this.request, responsePayload.status, responsePayload.statusText, headersObjectToArray(responsePayload.headers, ',', setCookieSeparator), timing, getResponseBody); } } diff --git a/tests/page/page-network-request.spec.ts b/tests/page/page-network-request.spec.ts index 4d32fd0f15..902cf559f0 100644 --- a/tests/page/page-network-request.spec.ts +++ b/tests/page/page-network-request.spec.ts @@ -271,9 +271,12 @@ it('should report all headers', async ({ page, server, browserName, platform }) server.setRoute('/headers', (req, res) => { for (let i = 0; i < req.rawHeaders.length; i += 2) expectedHeaders[req.rawHeaders[i].toLowerCase()] = req.rawHeaders[i + 1]; + if (browserName === 'webkit' && platform === 'win32') { + delete expectedHeaders['accept-encoding']; + delete expectedHeaders['accept-language']; + } res.end(); }); - await page.goto(server.EMPTY_PAGE); const [request] = await Promise.all([ page.waitForRequest('**/*'), diff --git a/tests/page/page-network-response.spec.ts b/tests/page/page-network-response.spec.ts index 34fd0f96c4..5e7b5f0cad 100644 --- a/tests/page/page-network-response.spec.ts +++ b/tests/page/page-network-response.spec.ts @@ -118,7 +118,8 @@ it('should return status text', async ({page, server}) => { expect(response.statusText()).toBe('cool!'); }); -it('should report all headers', async ({ page, server }) => { +it('should report all headers', async ({ page, server, browserName, platform }) => { + it.fixme(browserName === 'webkit' && platform === 'win32', 'libcurl does not support non-set-cookie multivalue headers'); const expectedHeaders = { 'header-a': ['value-a', 'value-a-1', 'value-a-2'], 'header-b': ['value-b'],