Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

cherry-pick(#12250): fix(electron): do not attach external debugger when running Electron tests

Browse source
This commit is contained in:
Pavel Feldman 2022-02-19 17:46:26 -08:00
parent 0037acffc6
commit 5b17ca9d56
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
packages/playwright-core/src/server/electron/electron.ts
View file

@ -127,10 +127,15 @@ export class Electron extends SdkObject {
const artifactsDir = await fs.promises.mkdtemp(ARTIFACTS_FOLDER); const artifactsDir = await fs.promises.mkdtemp(ARTIFACTS_FOLDER);
const browserLogsCollector = new RecentLogsCollector(); const browserLogsCollector = new RecentLogsCollector();
const env = options.env ? envArrayToObject(options.env) : process.env;
// When debugging Playwright test that runs Electron, NODE_OPTIONS
// will make the debugger attach to Electron's Node. But Playwright
// also needs to attach to drive the automation. Disable external debugging.
delete env.NODE_OPTIONS;
const { launchedProcess, gracefullyClose, kill } = await launchProcess({ const { launchedProcess, gracefullyClose, kill } = await launchProcess({
command: options.executablePath || require('electron/index.js'), command: options.executablePath || require('electron/index.js'),
args: electronArguments, args: electronArguments,
env: options.env ? envArrayToObject(options.env) : process.env, env,
log: (message: string) => { log: (message: string) => {
progress.log(message); progress.log(message);
browserLogsCollector.log(message); browserLogsCollector.log(message);