diff --git a/test/accessibility.spec.js b/test/accessibility.spec.js index 902e8c06ff..b399b81a33 100644 --- a/test/accessibility.spec.js +++ b/test/accessibility.spec.js @@ -85,7 +85,7 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT, }; expect(await page.accessibility.snapshot()).toEqual(golden); }); - it.skip(WEBKIT && !MAC)('should work with regular text', async({page}) => { + it.fail(WEBKIT && !MAC)('should work with regular text', async({page}) => { await page.setContent(`
Hello World
`); const snapshot = await page.accessibility.snapshot(); expect(snapshot.children[0]).toEqual({ diff --git a/test/capabilities.spec.js b/test/capabilities.spec.js index 09bb059613..e4cd4169f4 100644 --- a/test/capabilities.spec.js +++ b/test/capabilities.spec.js @@ -26,7 +26,7 @@ module.exports.describe = function({testRunner, expect, WIN, WEBKIT}) { const {beforeAll, beforeEach, afterAll, afterEach} = testRunner; describe('Capabilities', function() { - it.skip(WEBKIT && WIN)('Web Assembly should work', async function({page, server}) { + it.fail(WEBKIT && WIN)('Web Assembly should work', async function({page, server}) { await page.goto(server.PREFIX + '/wasm/table2.html'); expect(await page.evaluate(() => loadTable())).toBe('42, 83'); }); diff --git a/test/chromium/pdf.spec.js b/test/chromium/pdf.spec.js index 64df44a300..6ffde1d5f2 100644 --- a/test/chromium/pdf.spec.js +++ b/test/chromium/pdf.spec.js @@ -26,7 +26,7 @@ module.exports.describe = function({testRunner, expect, headless, ASSETS_DIR}) { const {beforeAll, beforeEach, afterAll, afterEach} = testRunner; // Printing to pdf is currently only supported in headless - describe.skip(!headless)('Page.pdf', function() { + describe.fail(!headless)('Page.pdf', function() { it('should be able to save file', async({page, server}) => { const outputFile = path.join(ASSETS_DIR, 'output.pdf'); await page.pdf({path: outputFile}); diff --git a/test/click.spec.js b/test/click.spec.js index fbdaf3de18..8b249d7beb 100644 --- a/test/click.spec.js +++ b/test/click.spec.js @@ -326,7 +326,7 @@ module.exports.describe = function({testRunner, expect, playwright, FFOX, CHROMI expect(await page.evaluate(() => offsetX)).toBe(WEBKIT ? 12 * 2 + 20 : 20); expect(await page.evaluate(() => offsetY)).toBe(WEBKIT ? 12 * 2 + 10 : 10); }); - it.skip(FFOX)('should click a very large button with offset', async({page, server}) => { + it.fail(FFOX)('should click a very large button with offset', async({page, server}) => { await page.goto(server.PREFIX + '/input/button.html'); await page.$eval('button', button => button.style.borderWidth = '8px'); await page.$eval('button', button => button.style.height = button.style.width = '2000px'); @@ -336,7 +336,7 @@ module.exports.describe = function({testRunner, expect, playwright, FFOX, CHROMI expect(await page.evaluate(() => offsetX)).toBe(WEBKIT ? 1900 + 8 : 1900); expect(await page.evaluate(() => offsetY)).toBe(WEBKIT ? 1910 + 8 : 1910); }); - it.skip(FFOX)('should click a button in scrolling container with offset', async({page, server}) => { + it.fail(FFOX)('should click a button in scrolling container with offset', async({page, server}) => { await page.goto(server.PREFIX + '/input/button.html'); await page.$eval('button', button => { const container = document.createElement('div'); diff --git a/test/cookies.spec.js b/test/cookies.spec.js index 2195ee8d5a..1cdccdcb1f 100644 --- a/test/cookies.spec.js +++ b/test/cookies.spec.js @@ -54,7 +54,7 @@ module.exports.describe = function({testRunner, expect, playwright, defaultBrows expect(cookies.length).toBe(1); expect(cookies[0].httpOnly).toBe(true); }); - it.skip(WEBKIT && !MAC)('should properly report "Strict" sameSite cookie', async({context, page, server}) => { + it.fail(WEBKIT && !MAC)('should properly report "Strict" sameSite cookie', async({context, page, server}) => { server.setRoute('/empty.html', (req, res) => { res.setHeader('Set-Cookie', 'name=value;SameSite=Strict'); res.end(); @@ -64,7 +64,7 @@ module.exports.describe = function({testRunner, expect, playwright, defaultBrows expect(cookies.length).toBe(1); expect(cookies[0].sameSite).toBe('Strict'); }); - it.skip(WEBKIT && !MAC)('should properly report "Lax" sameSite cookie', async({context, page, server}) => { + it.fail(WEBKIT && !MAC)('should properly report "Lax" sameSite cookie', async({context, page, server}) => { server.setRoute('/empty.html', (req, res) => { res.setHeader('Set-Cookie', 'name=value;SameSite=Lax'); res.end(); diff --git a/test/elementhandle.spec.js b/test/elementhandle.spec.js index 885fa30398..ad23d0fa79 100644 --- a/test/elementhandle.spec.js +++ b/test/elementhandle.spec.js @@ -299,7 +299,7 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT}) }); describe('ElementHandle.scrollIntoViewIfNeeded', function() { - it.skip(FFOX)('should work', async({page, server}) => { + it.fail(FFOX)('should work', async({page, server}) => { await page.goto(server.PREFIX + '/offscreenbuttons.html'); for (let i = 0; i < 11; ++i) { const button = await page.$('#btn' + i); diff --git a/test/emulation.spec.js b/test/emulation.spec.js index 4f49193075..9ed3d6d898 100644 --- a/test/emulation.spec.js +++ b/test/emulation.spec.js @@ -89,7 +89,7 @@ module.exports.describe = function({testRunner, expect, playwright, headless, FF expect(await page.evaluate(() => Modernizr.touchevents)).toBe(true); await context.close(); }); - it.skip(FFOX)('should support landscape emulation', async({browser, server}) => { + it.fail(FFOX)('should support landscape emulation', async({browser, server}) => { const context1 = await browser.newContext({ viewport: iPhone.viewport }); const page1 = await context1.newPage(); await page1.goto(server.PREFIX + '/mobile.html'); @@ -100,7 +100,7 @@ module.exports.describe = function({testRunner, expect, playwright, headless, FF await context1.close(); await context2.close(); }); - it.skip(FFOX || WEBKIT)('should fire orientationchange event', async({browser, server}) => { + it.fail(FFOX || WEBKIT)('should fire orientationchange event', async({browser, server}) => { const context = await browser.newContext({ viewport: { width: 300, height: 400, isMobile: true } }); const page = await context.newPage(); await page.goto(server.PREFIX + '/mobile.html'); @@ -118,14 +118,14 @@ module.exports.describe = function({testRunner, expect, playwright, headless, FF expect((await event2).text()).toBe('2'); await context.close(); }); - it.skip(FFOX)('default mobile viewports to 980 width', async({browser, server}) => { + it.fail(FFOX)('default mobile viewports to 980 width', async({browser, server}) => { const context = await browser.newContext({ viewport: {width: 320, height: 480, isMobile: true} }); const page = await context.newPage(); await page.goto(server.PREFIX + '/empty.html'); expect(await page.evaluate(() => window.innerWidth)).toBe(980); await context.close(); }); - it.skip(FFOX)('respect meta viewport tag', async({browser, server}) => { + it.fail(FFOX)('respect meta viewport tag', async({browser, server}) => { const context = await browser.newContext({ viewport: {width: 320, height: 480, isMobile: true} }); const page = await context.newPage(); await page.goto(server.PREFIX + '/mobile.html'); @@ -199,7 +199,7 @@ module.exports.describe = function({testRunner, expect, playwright, headless, FF await page.emulateMedia({ colorScheme: 'bad' }).catch(e => error = e); expect(error.message).toBe('Unsupported color scheme: bad'); }); - it.skip(FFOX)('should work during navigation', async({page, server}) => { + it.fail(FFOX)('should work during navigation', async({page, server}) => { await page.emulateMedia({ colorScheme: 'light' }); const navigated = page.goto(server.EMPTY_PAGE); for (let i = 0; i < 9; i++) { @@ -213,7 +213,7 @@ module.exports.describe = function({testRunner, expect, playwright, headless, FF }); }); - describe.skip(FFOX)('BrowserContext({timezoneId})', function() { + describe.fail(FFOX)('BrowserContext({timezoneId})', function() { it('should work', async ({ browser }) => { const func = () => new Date(1479579154987).toString(); { @@ -253,7 +253,7 @@ module.exports.describe = function({testRunner, expect, playwright, headless, FF }); }); - describe.skip(FFOX)('BrowserContext({locale})', function() { + describe.fail(FFOX)('BrowserContext({locale})', function() { it('should affect accept-language header', async({browser, server}) => { const context = await browser.newContext({ locale: 'fr-CH' }); const page = await context.newPage(); @@ -307,7 +307,7 @@ module.exports.describe = function({testRunner, expect, playwright, headless, FF }); describe('focus', function() { - it.skip(!headless)('should think that it is focused by default', async({page}) => { + it.fail(!headless)('should think that it is focused by default', async({page}) => { expect(await page.evaluate('document.hasFocus()')).toBe(true); }); }); diff --git a/test/evaluation.spec.js b/test/evaluation.spec.js index 22766d14cc..154fcaad1e 100644 --- a/test/evaluation.spec.js +++ b/test/evaluation.spec.js @@ -259,7 +259,7 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT}) expect(result).toEqual([42]); }); // Works in WebKit, but slow - it.skip(FFOX)('should transfer 100Mb of data from page to node.js', async({page, server}) => { + it.fail(FFOX)('should transfer 100Mb of data from page to node.js', async({page, server}) => { const a = await page.evaluate(() => Array(100 * 1024 * 1024 + 1).join('a')); expect(a.length).toBe(100 * 1024 * 1024); }); @@ -425,7 +425,7 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT}) const error = await page.evaluate(body => body.innerHTML, bodyHandle).catch(e => e); expect(error.message).toContain('Unable to adopt element handle from a different document'); }); - it.skip(FFOX)('should return non-empty Node.constructor.name in utility context', async({page,server}) => { + it.fail(FFOX)('should return non-empty Node.constructor.name in utility context', async({page,server}) => { await page.goto(server.EMPTY_PAGE); await utils.attachFrame(page, 'frame1', server.EMPTY_PAGE); const frame = page.frames()[1]; diff --git a/test/features/permissions.spec.js b/test/features/permissions.spec.js index af38b1c09f..99e20172fe 100644 --- a/test/features/permissions.spec.js +++ b/test/features/permissions.spec.js @@ -27,7 +27,7 @@ module.exports.describe = function({testRunner, expect, WEBKIT}) { const {beforeAll, beforeEach, afterAll, afterEach} = testRunner; // Permissions API is not implemented in WebKit (see https://developer.mozilla.org/en-US/docs/Web/API/Permissions_API) - describe.skip(WEBKIT)('Permissions', function() { + describe.fail(WEBKIT)('Permissions', function() { function getPermission(page, name) { return page.evaluate(name => navigator.permissions.query({name}).then(result => result.state), name); } diff --git a/test/geolocation.spec.js b/test/geolocation.spec.js index 4cc0f67ac5..337cc51b94 100644 --- a/test/geolocation.spec.js +++ b/test/geolocation.spec.js @@ -23,7 +23,7 @@ module.exports.describe = function ({ testRunner, expect, FFOX, WEBKIT }) { const {it, fit, xit, dit} = testRunner; const {beforeAll, beforeEach, afterAll, afterEach} = testRunner; - describe.skip(FFOX)('Overrides.setGeolocation', function() { + describe.fail(FFOX)('Overrides.setGeolocation', function() { it('should work', async({page, server, context}) => { await context.setPermissions(server.PREFIX, ['geolocation']); await page.goto(server.EMPTY_PAGE); diff --git a/test/headful.spec.js b/test/headful.spec.js index 90b0ac12d9..2a9a607c8a 100644 --- a/test/headful.spec.js +++ b/test/headful.spec.js @@ -41,7 +41,7 @@ module.exports.describe = function({testRunner, expect, playwright, defaultBrows await removeUserDataDir(userDataDir); }); // see https://github.com/microsoft/playwright/issues/717 - it.skip((WIN && CHROMIUM) || FFOX)('headless should be able to read cookies written by headful', async({server}) => { + it.fail((WIN && CHROMIUM) || FFOX)('headless should be able to read cookies written by headful', async({server}) => { const userDataDir = await makeUserDataDir(); // Write a cookie in headful chrome const headfulContext = await playwright.launchPersistent(userDataDir, headfulOptions); @@ -59,7 +59,7 @@ module.exports.describe = function({testRunner, expect, playwright, defaultBrows await removeUserDataDir(userDataDir); expect(cookie).toBe('foo=true'); }); - it.skip(FFOX)('should close browser with beforeunload page', async({server}) => { + it.fail(FFOX)('should close browser with beforeunload page', async({server}) => { const userDataDir = await makeUserDataDir(); const browserContext = await playwright.launchPersistent(userDataDir, headfulOptions); const page = await browserContext.newPage(); diff --git a/test/interception.spec.js b/test/interception.spec.js index 035f84295d..837e1905dc 100644 --- a/test/interception.spec.js +++ b/test/interception.spec.js @@ -524,7 +524,7 @@ module.exports.describe = function({testRunner, expect, defaultBrowserOptions, p }); }); - describe.skip(FFOX)('Interception.setOfflineMode', function() { + describe.fail(FFOX)('Interception.setOfflineMode', function() { it('should work', async({page, server}) => { await page.setOfflineMode(true); let error = null; diff --git a/test/keyboard.spec.js b/test/keyboard.spec.js index 806c7c89db..9d6ae15221 100644 --- a/test/keyboard.spec.js +++ b/test/keyboard.spec.js @@ -78,7 +78,7 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT, await page.keyboard.sendCharacters('a'); expect(await page.evaluate(() => document.querySelector('textarea').value)).toBe('å—ša'); }); - it.skip(FFOX)('should report shiftKey', async({page, server}) => { + it.fail(FFOX)('should report shiftKey', async({page, server}) => { await page.goto(server.PREFIX + '/input/keyboard.html'); const keyboard = page.keyboard; const codeForKey = {'Shift': 16, 'Alt': 18, 'Control': 17}; @@ -241,7 +241,7 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT, await textarea.type('👹 Tokyo street Japan 🇯🇵'); expect(await frame.$eval('textarea', textarea => textarea.value)).toBe('👹 Tokyo street Japan 🇯🇵'); }); - it.skip(CHROMIUM && MAC)('should handle selectAll', async({page, server}) => { + it.fail(CHROMIUM && MAC)('should handle selectAll', async({page, server}) => { await page.goto(server.PREFIX + '/input/textarea.html'); const textarea = await page.$('textarea'); await textarea.type('some text'); @@ -252,7 +252,7 @@ module.exports.describe = function({testRunner, expect, FFOX, CHROMIUM, WEBKIT, await page.keyboard.press('Backspace'); expect(await page.$eval('textarea', textarea => textarea.value)).toBe(''); }); - it.skip(CHROMIUM && MAC)('should be able to prevent selectAll', async({page, server}) => { + it.fail(CHROMIUM && MAC)('should be able to prevent selectAll', async({page, server}) => { await page.goto(server.PREFIX + '/input/textarea.html'); const textarea = await page.$('textarea'); await textarea.type('some text'); diff --git a/test/launcher.spec.js b/test/launcher.spec.js index ac81ad3281..f91c2d2f2f 100644 --- a/test/launcher.spec.js +++ b/test/launcher.spec.js @@ -283,7 +283,7 @@ module.exports.describe = function({testRunner, expect, defaultBrowserOptions, p // This might throw. See https://github.com/GoogleChrome/puppeteer/issues/2778 await removeUserDataDir(userDataDir); }); - it.skip(FFOX)('userDataDir option should restore state', async({server}) => { + it.fail(FFOX)('userDataDir option should restore state', async({server}) => { const userDataDir = await makeUserDataDir(); const browserContext = await playwright.launchPersistent(userDataDir, defaultBrowserOptions); const page = await browserContext.newPage(); @@ -309,7 +309,7 @@ module.exports.describe = function({testRunner, expect, defaultBrowserOptions, p await removeUserDataDir(userDataDir2); }); // See https://github.com/microsoft/playwright/issues/717 - it.skip(FFOX || (WIN && CHROMIUM))('userDataDir option should restore cookies', async({server}) => { + it.fail(FFOX || (WIN && CHROMIUM))('userDataDir option should restore cookies', async({server}) => { const userDataDir = await makeUserDataDir(); const browserContext = await playwright.launchPersistent(userDataDir, defaultBrowserOptions); const page = await browserContext.newPage(); diff --git a/test/network.spec.js b/test/network.spec.js index 17a339e2c3..080eac72ce 100644 --- a/test/network.spec.js +++ b/test/network.spec.js @@ -231,7 +231,7 @@ module.exports.describe = function({testRunner, expect, MAC, WIN, FFOX, CHROMIUM expect(responses[0].request()).toBeTruthy(); }); - it.skip(FFOX)('Page.Events.RequestFailed', async({page, server}) => { + it.fail(FFOX)('Page.Events.RequestFailed', async({page, server}) => { server.setRoute('/one-style.css', (req, res) => { req.socket.write('deadbeef'); req.socket.end(); diff --git a/test/page.spec.js b/test/page.spec.js index 1e4bce6058..bc359adc23 100644 --- a/test/page.spec.js +++ b/test/page.spec.js @@ -667,7 +667,7 @@ module.exports.describe = function({testRunner, expect, headless, playwright, FF }); // Firefox fires onload for blocked script before it issues the CSP console error. - it.skip(FFOX)('should throw when added with content to the CSP page', async({page, server}) => { + it.fail(FFOX)('should throw when added with content to the CSP page', async({page, server}) => { await page.goto(server.PREFIX + '/csp.html'); let error = null; await page.addScriptTag({ content: 'window.__injected = 35;' }).catch(e => error = e); diff --git a/test/popup.spec.js b/test/popup.spec.js index cf58b6fec7..9163e8d5fa 100644 --- a/test/popup.spec.js +++ b/test/popup.spec.js @@ -20,7 +20,7 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE const {beforeAll, beforeEach, afterAll, afterEach} = testRunner; describe('window.open', function() { - it.skip(CHROMIUM)('should inherit user agent from browser context', async function({browser, server}) { + it.fail(CHROMIUM)('should inherit user agent from browser context', async function({browser, server}) { const context = await browser.newContext({ userAgent: 'hey' }); @@ -36,7 +36,7 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE expect(userAgent).toBe('hey'); expect(request.headers['user-agent']).toBe('hey'); }); - it.skip(CHROMIUM)('should inherit extra headers from browser context', async function({browser, server}) { + it.fail(CHROMIUM)('should inherit extra headers from browser context', async function({browser, server}) { const context = await browser.newContext({ extraHTTPHeaders: { 'foo': 'bar' }, }); @@ -48,7 +48,7 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE await context.close(); expect(request.headers['foo']).toBe('bar'); }); - it.skip(CHROMIUM)('should inherit touch support from browser context', async function({browser, server}) { + it.fail(CHROMIUM)('should inherit touch support from browser context', async function({browser, server}) { const context = await browser.newContext({ viewport: { width: 400, height: 500, isMobile: true } }); @@ -61,7 +61,7 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE await context.close(); expect(hasTouch).toBe(true); }); - it.skip(CHROMIUM)('should inherit viewport size from browser context', async function({browser, server}) { + it.fail(CHROMIUM)('should inherit viewport size from browser context', async function({browser, server}) { const context = await browser.newContext({ viewport: { width: 400, height: 500 } }); @@ -74,7 +74,7 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE await context.close(); expect(size).toEqual({width: 400, height: 500}); }); - it.skip(CHROMIUM)('should apply addInitScript from browser context', async function({browser, server}) { + it.fail(CHROMIUM)('should apply addInitScript from browser context', async function({browser, server}) { const context = await browser.newContext(); await context.addInitScript(() => window.injected = 123); const page = await context.newPage(); @@ -100,7 +100,7 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE expect(await popup.evaluate(() => !!window.opener)).toBe(true); await context.close(); }); - it.skip(CHROMIUM)('should work with empty url', async({browser}) => { + it.fail(CHROMIUM)('should work with empty url', async({browser}) => { const context = await browser.newContext(); const page = await context.newPage(); const [popup] = await Promise.all([ diff --git a/test/screenshot.spec.js b/test/screenshot.spec.js index c14333e9fe..68a11450ea 100644 --- a/test/screenshot.spec.js +++ b/test/screenshot.spec.js @@ -117,7 +117,7 @@ module.exports.describe = function({testRunner, expect, product, FFOX, CHROMIUM, expect(screenshots[i]).toBeGolden(`grid-cell-${i}.png`); await Promise.all(pages.map(page => page.close())); }); - it.skip(FFOX)('should allow transparency', async({page, server}) => { + it.fail(FFOX)('should allow transparency', async({page, server}) => { await page.setViewportSize({ width: 50, height: 150 }); await page.setContent(`