From 5bde171657c64b6914885d85867eab1a7d9db7de Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Thu, 2 Dec 2021 13:04:15 -0800 Subject: [PATCH] fix(chromium): disable AutoExpandDetailsElement as it breaks the web (#10679) --- .../playwright-core/src/server/chromium/chromium.ts | 2 +- tests/page/locator-convenience.spec.ts | 13 +++++++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/packages/playwright-core/src/server/chromium/chromium.ts b/packages/playwright-core/src/server/chromium/chromium.ts index 5544aed14f..8dc285c4f2 100644 --- a/packages/playwright-core/src/server/chromium/chromium.ts +++ b/packages/playwright-core/src/server/chromium/chromium.ts @@ -296,7 +296,7 @@ const DEFAULT_ARGS = [ '--disable-default-apps', '--disable-dev-shm-usage', '--disable-extensions', - '--disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose,MediaRouter,AcceptCHFrame', + '--disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose,MediaRouter,AcceptCHFrame,AutoExpandDetailsElement', '--allow-pre-commit-input', '--disable-hang-monitor', '--disable-ipc-flooding-protection', diff --git a/tests/page/locator-convenience.spec.ts b/tests/page/locator-convenience.spec.ts index c04e732dae..9ebf21fbb2 100644 --- a/tests/page/locator-convenience.spec.ts +++ b/tests/page/locator-convenience.spec.ts @@ -178,3 +178,16 @@ it('allInnerTexts should work', async ({ page }) => { await page.setContent(`
A
B
C
`); expect(await page.locator('div').allInnerTexts()).toEqual(['A', 'B', 'C']); }); + +it('isVisible and isHidden should work with details', async ({ page }) => { + await page.setContent(`
+ click to open + `); + + await expect(page.locator('ul')).toBeHidden(); +});