Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: try to unflake network idle tests (#4333)

Browse source 
I think that we are too slow to fire the second fetch during 500ms,
and so network idle happens prematurely.

The fix is to manually trigger the second fetch early enough.
This commit is contained in:
Dmitry Gozman 2020-11-04 07:35:19 -08:00 committed by GitHub
parent 890add98fe
commit 5c1149f954
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 22 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
test/assets/networkidle.js
View file

@ -1,18 +1,12 @@
async function sleep(delay) {
return new Promise(resolve => setTimeout(resolve, delay));
}
async function main() {
window.ws = new WebSocket('ws://localhost:' + window.location.port + '/ws');
window.ws.addEventListener('message', message => {});
const roundOne = Promise.all([
fetch('fetch-request-a.js'),
]);
await roundOne;
await sleep(50);
await fetch('fetch-request-d.js');
fetch('fetch-request-a.js');
window.top.fetchSecond = () => {
// Do not return the promise here.
fetch('fetch-request-b.js');
};
}
main();

33
test/page-network-idle.spec.ts
View file

@ -16,7 +16,7 @@
*/
import { it, expect } from './fixtures';
import type { Frame, Page } from '..';
import type { Frame } from '..';
import { TestServer } from '../utils/testserver';
it('should navigate to empty page with networkidle', async ({page, server}) => {
@ -25,22 +25,19 @@ it('should navigate to empty page with networkidle', async ({page, server}) => {
});
async function networkIdleTest(frame: Frame, server: TestServer, action: () => Promise<any>, isSetContent?: boolean) {
const finishResponse = response => {
response.statusCode = 404;
response.end(`File not found`);
};
const waitForRequest = suffix => {
const waitForRequest = (suffix: string) => {
return Promise.all([
server.waitForRequest(suffix),
(frame['_page'] as Page).waitForRequest(server.PREFIX + suffix),
frame.page().waitForRequest(server.PREFIX + suffix),
]);
};
const responses = {};
let responseA, responseB;
// Hold on to a bunch of requests without answering.
server.setRoute('/fetch-request-a.js', (req, res) => responses['a'] = res);
server.setRoute('/fetch-request-a.js', (req, res) => responseA = res);
const firstFetchResourceRequested = waitForRequest('/fetch-request-a.js');
server.setRoute('/fetch-request-d.js', (req, res) => responses['d'] = res);
const secondFetchResourceRequested = waitForRequest('/fetch-request-d.js');
server.setRoute('/fetch-request-b.js', (req, res) => responseB = res);
const secondFetchResourceRequested = waitForRequest('/fetch-request-b.js');
const waitForLoadPromise = isSetContent ? Promise.resolve() : frame.waitForNavigation({ waitUntil: 'load' });
@ -60,17 +57,21 @@ async function networkIdleTest(frame: Frame, server: TestServer, action: () => P
await firstFetchResourceRequested;
expect(actionFinished).toBe(false);
expect(responses['a']).toBeTruthy();
// Finishing response should trigger the second round.
finishResponse(responses['a']);
// Trigger the second request.
await frame.page().evaluate(() => window['fetchSecond']());
// Finish the first request.
responseA.statusCode = 404;
responseA.end(`File not found`);
// Wait for the second round to be requested.
await secondFetchResourceRequested;
expect(actionFinished).toBe(false);
// Finishing the last response should trigger networkidle.
// Finishing the second response should trigger networkidle.
let timerTriggered = false;
const timer = setTimeout(() => timerTriggered = true, 500);
finishResponse(responses['d']);
responseB.statusCode = 404;
responseB.end(`File not found`);
const response = await actionPromise;
clearTimeout(timer);