Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(line reporter): clarify about retries when going over total counter (#10901)

Browse source
This commit is contained in:
Dmitry Gozman 2021-12-13 19:06:13 -08:00 committed by GitHub
parent e775494991
commit 5c4ebdce54
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
packages/playwright-test/src/reporters/line.ts
View file

@ -46,7 +46,8 @@ class LineReporter extends BaseReporter {
private _dumpToStdio(test: TestCase | undefined, chunk: string | Buffer, stream: NodeJS.WriteStream) {
if (this.config.quiet)
return;
stream.write(`\u001B[1A\u001B[2K`);
if (!process.env.PWTEST_SKIP_TEST_OUTPUT)
stream.write(`\u001B[1A\u001B[2K`);
if (test && this._lastTest !== test) {
// Write new header for the output.
stream.write(colors.gray(formatTestTitle(this.config, test) + `\n`));
@ -59,12 +60,18 @@ class LineReporter extends BaseReporter {
override onTestEnd(test: TestCase, result: TestResult) {
super.onTestEnd(test, result);
const width = process.stdout.columns! - 1;
const title = `[${++this._current}/${this.totalTestCount}] ${formatTestTitle(this.config, test)}`.substring(0, width);
process.stdout.write(`\u001B[1A\u001B[2K${title}\n`);
const width = process.env.PWTEST_SKIP_TEST_OUTPUT ? 79 : process.stdout.columns! - 1;
++this._current;
const retriesSuffix = this.totalTestCount < this._current ? ` (retries)` : ``;
const title = `[${this._current}/${this.totalTestCount}]${retriesSuffix} ${formatTestTitle(this.config, test)}`.substring(0, width);
if (process.env.PWTEST_SKIP_TEST_OUTPUT)
process.stdout.write(`${title}\n`);
else
process.stdout.write(`\u001B[1A\u001B[2K${title}\n`);
if (!this.willRetry(test) && (test.outcome() === 'flaky' || test.outcome() === 'unexpected')) {
process.stdout.write(`\u001B[1A\u001B[2K`);
if (!process.env.PWTEST_SKIP_TEST_OUTPUT)
process.stdout.write(`\u001B[1A\u001B[2K`);
console.log(formatFailure(this.config, test, {
index: ++this._failures
}).message);
@ -73,7 +80,8 @@ class LineReporter extends BaseReporter {
}
override async onEnd(result: FullResult) {
process.stdout.write(`\u001B[1A\u001B[2K`);
if (!process.env.PWTEST_SKIP_TEST_OUTPUT)
process.stdout.write(`\u001B[1A\u001B[2K`);
await super.onEnd(result);
this.epilogue(false);
}

4
tests/playwright-test/reporter-line.spec.ts
View file

@ -26,6 +26,10 @@ test('render unexpected after retry', async ({ runInlineTest }) => {
`,
}, { retries: 3, reporter: 'line' });
const text = stripAscii(result.output);
expect(text).toContain('[1/1] a.test.js:6:7 › one');
expect(text).toContain('[2/1] (retries) a.test.js:6:7 › one');
expect(text).toContain('[3/1] (retries) a.test.js:6:7 › one');
expect(text).toContain('[4/1] (retries) a.test.js:6:7 › one');
expect(text).toContain('1 failed');
expect(text).toContain('1) a.test');
expect(text).not.toContain('2) a.test');