Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(webkit): do not access mainFrame when initialization has failed (#1825)

Browse source
This commit is contained in:
Dmitry Gozman 2020-04-16 10:59:27 -07:00 committed by GitHub
parent 08c8a74e09
commit 5e18378df7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/webkit/wkPage.ts
View file

@ -262,7 +262,7 @@ export class WKPage implements PageDelegate {
} }
if (targetInfo.isPaused) if (targetInfo.isPaused)
this._pageProxySession.send('Target.resume', { targetId: targetInfo.targetId }).catch(debugError); this._pageProxySession.send('Target.resume', { targetId: targetInfo.targetId }).catch(debugError);
if (this._page.mainFrame().url() === '') { if ((pageOrError instanceof Page) && this._page.mainFrame().url() === '') {
// Initial empty page has an empty url. We should wait until the first real url has been loaded, // Initial empty page has an empty url. We should wait until the first real url has been loaded,
// even if that url is about:blank. This is especially important for popups, where we need the // even if that url is about:blank. This is especially important for popups, where we need the
// actual url before interacting with it. // actual url before interacting with it.