From 5e985a664ab492f56f411653524432e54bc53e93 Mon Sep 17 00:00:00 2001
From: Ryan Rosello <goneby30+github@gmail.com>
Date: Sun, 7 Jul 2024 06:49:18 +1000
Subject: [PATCH] chore(html-reporter) ammend test for page title and favicon

---
 .../html-reporter/src/testCaseView.spec.tsx    | 18 ++++++++++++------
 packages/html-reporter/src/testCaseView.tsx    |  2 +-
 2 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/packages/html-reporter/src/testCaseView.spec.tsx b/packages/html-reporter/src/testCaseView.spec.tsx
index dd9b3b83b1..f1f8e45306 100644
--- a/packages/html-reporter/src/testCaseView.spec.tsx
+++ b/packages/html-reporter/src/testCaseView.spec.tsx
@@ -77,6 +77,18 @@ test('should render test case', async ({ mount }) => {
   await expect(component.getByText('My test')).toBeVisible();
 });
 
+test('should correctly set the page title and favicon', async ({ mount, page }) => {
+  await mount(<TestCaseView projectNames={['chromium', 'webkit']} test={testCase} run={0} anchor=''></TestCaseView>);
+  expect(await page.locator('link[rel="icon"]').getAttribute('href')).toEqual('../logo_expected.svg');
+  expect(await page.title()).toEqual(`| ${testCase.title}`);
+});
+
+test('should fallback to default title and favicon', async ({ mount, page }) => {
+  await mount(<TestCaseView projectNames={['chromium', 'webkit']} test={undefined} run={0} anchor=''></TestCaseView>);
+  expect(await page.locator('link[rel="icon"]').getAttribute('href')).toEqual('../logo_default.svg');
+  expect(await page.title()).toEqual('Playwright Test Report');
+});
+
 const linkRenderingTestCase: TestCase = {
   testId: 'testid',
   title: 'My test',
@@ -95,12 +107,6 @@ const linkRenderingTestCase: TestCase = {
   results: [result]
 };
 
-test('should correctly set the page title and favicon', async ({ mount, page }) => {
-  await mount(<TestCaseView projectNames={['chromium', 'webkit']} test={linkRenderingTestCase} run={0} anchor=''></TestCaseView>);
-  expect(await page.locator('link[rel="icon"]').getAttribute('href')).toEqual('../logo_expected.svg');
-  expect(await page.title()).toEqual(`| ${linkRenderingTestCase.title}`);
-});
-
 test('should correctly render links in annotations', async ({ mount, page }) => {
   const component = await mount(<TestCaseView projectNames={['chromium', 'webkit']} test={linkRenderingTestCase} run={0} anchor=''></TestCaseView>);
   // const container = await(component.getByText('Annotations'));
diff --git a/packages/html-reporter/src/testCaseView.tsx b/packages/html-reporter/src/testCaseView.tsx
index 418edb58cc..8637622155 100644
--- a/packages/html-reporter/src/testCaseView.tsx
+++ b/packages/html-reporter/src/testCaseView.tsx
@@ -45,7 +45,7 @@ export const TestCaseView: React.FC<{
   }, [test?.annotations]);
 
   React.useEffect(() => {
-    document.title = `| ${test?.title}` ?? 'Playwright Test Report';
+    document.title = test?.title ? `| ${test.title}` : 'Playwright Test Report';
     setSvgFavicon(test?.outcome);
   }, [test?.outcome, test?.title]);