Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Revert "fix: respect .only in --list mode" (#28770)

Browse source 
This reverts commit 9a5bfc54e5.

As it breaks extension.

Reference #28709
This commit is contained in:
Yury Semikhatsky 2023-12-22 11:03:30 -08:00 committed by GitHub
parent b62317c056
commit 5f14d42723
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/playwright/src/runner/tasks.ts
View file

@ -102,7 +102,7 @@ function addRunTasks(taskRunner: TaskRunner<TestRun>, config: FullConfigInternal
export function createTaskRunnerForList(config: FullConfigInternal, reporter: ReporterV2, mode: 'in-process' | 'out-of-process', options: { failOnLoadErrors: boolean }): TaskRunner<TestRun> { export function createTaskRunnerForList(config: FullConfigInternal, reporter: ReporterV2, mode: 'in-process' | 'out-of-process', options: { failOnLoadErrors: boolean }): TaskRunner<TestRun> {
const taskRunner = new TaskRunner<TestRun>(reporter, config.config.globalTimeout); const taskRunner = new TaskRunner<TestRun>(reporter, config.config.globalTimeout);
taskRunner.addTask('load tests', createLoadTask(mode, { ...options, filterOnly: true })); taskRunner.addTask('load tests', createLoadTask(mode, { ...options, filterOnly: false }));
taskRunner.addTask('report begin', createReportBeginTask()); taskRunner.addTask('report begin', createReportBeginTask());
return taskRunner; return taskRunner;
} }

6
tests/playwright-test/list-mode.spec.ts
View file

@ -152,8 +152,7 @@ test('should report errors', async ({ runInlineTest }) => {
expect(result.output).toContain('> 3 | oh = 2;'); expect(result.output).toContain('> 3 | oh = 2;');
}); });
test('should respect .only', async ({ runInlineTest }) => { test('should ignore .only', async ({ runInlineTest }) => {
test.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/28709' });
const result = await runInlineTest({ const result = await runInlineTest({
'a.test.js': ` 'a.test.js': `
const { test, expect } = require('@playwright/test'); const { test, expect } = require('@playwright/test');
@ -168,8 +167,9 @@ test('should respect .only', async ({ runInlineTest }) => {
expect(result.exitCode).toBe(0); expect(result.exitCode).toBe(0);
expect(result.output).toContain([ expect(result.output).toContain([
`Listing tests:`, `Listing tests:`,
` a.test.js:3:7 › example1`,
` a.test.js:6:12 › example2`, ` a.test.js:6:12 › example2`,
`Total: 1 test in 1 file` `Total: 2 tests in 1 file`
].join('\n')); ].join('\n'));
}); });