feat(webkit): roll to r1674 (#15384)
Also reverted screenshot test changes from 4de14e7 as the breaking change was reverted upstream in Revert [251706@main] getComputedStyle(img).height returns string of a rounded int not a float WebKit/WebKit#1902
|
|
@ -33,7 +33,7 @@
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
"name": "webkit",
|
"name": "webkit",
|
||||||
"revision": "1673",
|
"revision": "1674",
|
||||||
"installByDefault": true,
|
"installByDefault": true,
|
||||||
"revisionOverrides": {
|
"revisionOverrides": {
|
||||||
"mac10.14": "1446",
|
"mac10.14": "1446",
|
||||||
|
|
|
||||||
|
Before Width: | Height: | Size: 632 B After Width: | Height: | Size: 443 B |
|
Before Width: | Height: | Size: 39 KiB After Width: | Height: | Size: 32 KiB |
|
Before Width: | Height: | Size: 632 B After Width: | Height: | Size: 443 B |
|
Before Width: | Height: | Size: 461 B After Width: | Height: | Size: 296 B |
|
Before Width: | Height: | Size: 2.4 KiB After Width: | Height: | Size: 2.4 KiB |
|
Before Width: | Height: | Size: 17 KiB After Width: | Height: | Size: 15 KiB |
|
Before Width: | Height: | Size: 24 KiB After Width: | Height: | Size: 24 KiB |
|
Before Width: | Height: | Size: 98 KiB After Width: | Height: | Size: 80 KiB |
|
Before Width: | Height: | Size: 1.7 KiB After Width: | Height: | Size: 1.3 KiB |
|
Before Width: | Height: | Size: 636 B After Width: | Height: | Size: 445 B |
|
|
@ -26,10 +26,6 @@ it('should work', async ({ page, server, browserName, headless, isLinux }) => {
|
||||||
await page.goto(server.PREFIX + '/grid.html');
|
await page.goto(server.PREFIX + '/grid.html');
|
||||||
const elementHandle = await page.$('.box:nth-of-type(13)');
|
const elementHandle = await page.$('.box:nth-of-type(13)');
|
||||||
const box = await elementHandle.boundingBox();
|
const box = await elementHandle.boundingBox();
|
||||||
if (browserName === 'webkit') {
|
|
||||||
// Upstream regression: https://bugs.webkit.org/show_bug.cgi?id=242079
|
|
||||||
box.y = Math.ceil(box.y);
|
|
||||||
}
|
|
||||||
expect(box).toEqual({ x: 100, y: 50, width: 50, height: 50 });
|
expect(box).toEqual({ x: 100, y: 50, width: 50, height: 50 });
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|
|
||||||
|
Before Width: | Height: | Size: 636 B After Width: | Height: | Size: 445 B |
|
|
@ -114,10 +114,6 @@ it('should return bounding box', async ({ page, server, browserName, headless, i
|
||||||
await page.goto(server.PREFIX + '/grid.html');
|
await page.goto(server.PREFIX + '/grid.html');
|
||||||
const element = page.locator('.box:nth-of-type(13)');
|
const element = page.locator('.box:nth-of-type(13)');
|
||||||
const box = await element.boundingBox();
|
const box = await element.boundingBox();
|
||||||
if (browserName === 'webkit') {
|
|
||||||
// Upstream regression: https://bugs.webkit.org/show_bug.cgi?id=242079
|
|
||||||
box.y = Math.ceil(box.y);
|
|
||||||
}
|
|
||||||
expect(box).toEqual({ x: 100, y: 50, width: 50, height: 50 });
|
expect(box).toEqual({ x: 100, y: 50, width: 50, height: 50 });
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|
|
||||||
|
Before Width: | Height: | Size: 636 B After Width: | Height: | Size: 633 B |
|
Before Width: | Height: | Size: 461 B After Width: | Height: | Size: 296 B |
|
Before Width: | Height: | Size: 39 KiB After Width: | Height: | Size: 39 KiB |
|
Before Width: | Height: | Size: 81 KiB After Width: | Height: | Size: 81 KiB |
|
Before Width: | Height: | Size: 81 KiB After Width: | Height: | Size: 81 KiB |
|
Before Width: | Height: | Size: 2.4 KiB After Width: | Height: | Size: 1.8 KiB |
|
Before Width: | Height: | Size: 81 KiB After Width: | Height: | Size: 81 KiB |
|
Before Width: | Height: | Size: 18 KiB After Width: | Height: | Size: 13 KiB |
|
Before Width: | Height: | Size: 4 KiB After Width: | Height: | Size: 3.2 KiB |
|
Before Width: | Height: | Size: 39 KiB After Width: | Height: | Size: 32 KiB |
|
Before Width: | Height: | Size: 16 KiB After Width: | Height: | Size: 16 KiB |
|
Before Width: | Height: | Size: 16 KiB After Width: | Height: | Size: 16 KiB |
|
Before Width: | Height: | Size: 39 KiB After Width: | Height: | Size: 39 KiB |
|
Before Width: | Height: | Size: 39 KiB After Width: | Height: | Size: 39 KiB |