Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

feat(html): render inline attachments as monospace (#11214)

Browse source
This commit is contained in:
Pavel Feldman 2022-01-06 09:29:55 -08:00 committed by GitHub
parent 373042ed89
commit 5fa7d19f1c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/html-reporter/src/links.css
View file

@ -95,10 +95,11 @@
} }
} }
.attachment-link { .attachment-body {
white-space: pre-wrap; white-space: pre-wrap;
background-color: var(--color-canvas-subtle); background-color: var(--color-canvas-subtle);
margin-left: 24px; margin-left: 24px;
line-height: normal; line-height: normal;
padding: 8px; padding: 8px;
font-family: monospace;
} }

2
packages/html-reporter/src/links.tsx
View file

@ -74,7 +74,7 @@ export const AttachmentLink: React.FunctionComponent<{
{attachment.path && <a href={href || attachment.path} target='_blank'>{attachment.name}</a>} {attachment.path && <a href={href || attachment.path} target='_blank'>{attachment.name}</a>}
{attachment.body && <span>{attachment.name}</span>} {attachment.body && <span>{attachment.name}</span>}
</span>} loadChildren={attachment.body ? () => { </span>} loadChildren={attachment.body ? () => {
return [<div className='attachment-link'>{attachment.body}</div>]; return [<div className='attachment-body'>{attachment.body}</div>];
} : undefined} depth={0}></TreeItem>; } : undefined} depth={0}></TreeItem>;
}; };

8
tests/playwright-test/reporter-html.spec.ts
View file

@ -88,7 +88,7 @@ test('should not throw when attachment is missing', async ({ runInlineTest, page
await page.click('text=passes'); await page.click('text=passes');
await page.locator('text=Missing attachment "screenshot"').click(); await page.locator('text=Missing attachment "screenshot"').click();
const screenshotFile = testInfo.outputPath('test-results' , 'a-passes', 'screenshot.png'); const screenshotFile = testInfo.outputPath('test-results' , 'a-passes', 'screenshot.png');
await expect(page.locator('.attachment-link')).toHaveText(`Attachment file ${screenshotFile} is missing`); await expect(page.locator('.attachment-body')).toHaveText(`Attachment file ${screenshotFile} is missing`);
}); });
test('should include image diff', async ({ runInlineTest, page, showReport }) => { test('should include image diff', async ({ runInlineTest, page, showReport }) => {
@ -203,9 +203,9 @@ test('should include stdio', async ({ runInlineTest, page, showReport }) => {
await showReport(); await showReport();
await page.click('text=fails'); await page.click('text=fails');
await page.locator('text=stdout').click(); await page.locator('text=stdout').click();
await expect(page.locator('.attachment-link')).toHaveText('First line\nSecond line'); await expect(page.locator('.attachment-body')).toHaveText('First line\nSecond line');
await page.locator('text=stderr').click(); await page.locator('text=stderr').click();
await expect(page.locator('.attachment-link').nth(1)).toHaveText('Third line'); await expect(page.locator('.attachment-body').nth(1)).toHaveText('Third line');
}); });
test('should highlight error', async ({ runInlineTest, page, showReport }) => { test('should highlight error', async ({ runInlineTest, page, showReport }) => {
@ -402,7 +402,7 @@ test('should render text attachments as text', async ({ runInlineTest, page, sho
await page.click('text=example.txt'); await page.click('text=example.txt');
await page.click('text=example.json'); await page.click('text=example.json');
await page.click('text=example-utf16.txt'); await page.click('text=example-utf16.txt');
await expect(page.locator('.attachment-link')).toHaveText(['foo', '{"foo":1}', 'utf16 encoded']); await expect(page.locator('.attachment-body')).toHaveText(['foo', '{"foo":1}', 'utf16 encoded']);
}); });
test('should strikethough textual diff', async ({ runInlineTest, showReport, page }) => { test('should strikethough textual diff', async ({ runInlineTest, showReport, page }) => {