This commit is contained in:
Max Schmitt 2025-02-11 15:40:47 +01:00
parent 5764a76192
commit 5fba87f84e

View file

@ -20,7 +20,7 @@ import * as path from 'path';
import { normalizeProxySettings, validateBrowserContextOptions } from './browserContext'; import { normalizeProxySettings, validateBrowserContextOptions } from './browserContext';
import { DEFAULT_TIMEOUT, TimeoutSettings } from '../common/timeoutSettings'; import { DEFAULT_TIMEOUT, TimeoutSettings } from '../common/timeoutSettings';
import { ManualPromise, debugMode } from '../utils'; import { ManualPromise, assert, debugMode } from '../utils';
import { helper } from './helper'; import { helper } from './helper';
import { SdkObject } from './instrumentation'; import { SdkObject } from './instrumentation';
import { PipeTransport } from './pipeTransport'; import { PipeTransport } from './pipeTransport';
@ -188,8 +188,7 @@ export abstract class BrowserType extends SdkObject {
tempDirectories.push(artifactsDir); tempDirectories.push(artifactsDir);
if (userDataDir) { if (userDataDir) {
if (!path.isAbsolute(userDataDir)) assert(path.isAbsolute(userDataDir), 'userDataDir must be an absolute path');
throw new Error('userDataDir must be an absolute path');
// Firefox bails if the profile directory does not exist, Chrome creates it. We ensure consistent behavior here. // Firefox bails if the profile directory does not exist, Chrome creates it. We ensure consistent behavior here.
if (!await existsAsync(userDataDir)) if (!await existsAsync(userDataDir))
await fs.promises.mkdir(userDataDir, { recursive: true, mode: 0o700 }); await fs.promises.mkdir(userDataDir, { recursive: true, mode: 0o700 });