Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: unflake some chromium tests (#4521)

Browse source 
These should be passing for a while.
This commit is contained in:
Dmitry Gozman 2020-11-24 18:14:57 -08:00 committed by GitHub
parent 566c57eece
commit 60103229d8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
test/browsertype-launch.spec.ts
View file

@ -57,9 +57,7 @@ it('should throw if page argument is passed', (test, { browserName }) => {
expect(waitError.message).toContain('can not specify page');
});
it('should reject if launched browser fails immediately', (test, parameters) => {
test.fixme(`I'm getting ENCONRESET on this one.`);
}, async ({browserType, browserOptions}) => {
it('should reject if launched browser fails immediately', async ({browserType, browserOptions}) => {
const options = Object.assign({}, browserOptions, {executablePath: path.join(__dirname, 'assets', 'dummy_bad_browser_executable.js')});
let waitError = null;
await browserType.launch(options).catch(e => waitError = e);

4
test/defaultbrowsercontext-2.spec.ts
View file

@ -77,9 +77,7 @@ it('should support extraHTTPHeaders option', (test, { browserName, platform, hea
expect(request.headers['foo']).toBe('bar');
});
it('should accept userDataDir', (test, { browserName }) => {
test.flaky(browserName === 'chromium');
}, async ({createUserDataDir, browserType, browserOptions}) => {
it('should accept userDataDir', async ({createUserDataDir, browserType, browserOptions}) => {
const userDataDir = await createUserDataDir();
const context = await browserType.launchPersistentContext(userDataDir, browserOptions);
expect(fs.readdirSync(userDataDir).length).toBeGreaterThan(0);