From 6083926111f56903e1337aaebaaf4532e747280f Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Mon, 9 Jan 2023 09:33:09 -0800 Subject: [PATCH] chore: render readable title separator in errors (#19754) --- packages/playwright-test/src/reporters/base.ts | 3 +-- packages/playwright-test/src/runner.ts | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/playwright-test/src/reporters/base.ts b/packages/playwright-test/src/reporters/base.ts index 56782c901d..7acf9ce35f 100644 --- a/packages/playwright-test/src/reporters/base.ts +++ b/packages/playwright-test/src/reporters/base.ts @@ -99,8 +99,7 @@ export class BaseReporter implements ReporterInternal { } onError(error: TestError) { - if (!(error as any).__isNotAFatalError) - this._fatalErrors.push(error); + this._fatalErrors.push(error); } async onEnd(result: FullResult) { diff --git a/packages/playwright-test/src/runner.ts b/packages/playwright-test/src/runner.ts index e9cb606c20..be256ca61d 100644 --- a/packages/playwright-test/src/runner.ts +++ b/packages/playwright-test/src/runner.ts @@ -945,7 +945,7 @@ function createDuplicateTitlesErrors(config: FullConfigInternal, rootSuite: Suit for (const fileSuite of rootSuite.suites) { const testsByFullTitle = new Map(); for (const test of fileSuite.allTests()) { - const fullTitle = test.titlePath().slice(2).join('\x1e'); + const fullTitle = test.titlePath().slice(2).join(' › '); const existingTest = testsByFullTitle.get(fullTitle); if (existingTest) { const error: TestError = {