Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: allow tabbing from codemirror locator editor (#28116)

Browse source
This commit is contained in:
Pavel Feldman 2023-11-14 08:13:29 -08:00 committed by GitHub
parent 78293053b4
commit 60a37f37ef
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
packages/playwright-core/src/server/injected/recorder.ts
View file

@ -499,6 +499,12 @@ class TextAssertionTool implements RecorderTool {
consumeEvent(event); consumeEvent(event);
} }
onMouseDown(event: MouseEvent) {
const target = this._recorder.deepEventTarget(event);
if (target.nodeName === 'SELECT')
event.preventDefault();
}
onMouseMove(event: MouseEvent) { onMouseMove(event: MouseEvent) {
if (this._dialogElement) if (this._dialogElement)
return; return;
@ -520,7 +526,7 @@ class TextAssertionTool implements RecorderTool {
const target = this._hoverHighlight?.elements[0]; const target = this._hoverHighlight?.elements[0];
if (!target) if (!target)
return null; return null;
if (target.nodeName === 'INPUT' || target.nodeName === 'TEXTAREA') { if (target.nodeName === 'INPUT' || target.nodeName === 'TEXTAREA' || target.nodeName === 'SELECT') {
const { selector } = generateSelector(this._recorder.injectedScript, target, { testIdAttributeName: this._recorder.state.testIdAttributeName }); const { selector } = generateSelector(this._recorder.injectedScript, target, { testIdAttributeName: this._recorder.state.testIdAttributeName });
if (target.nodeName === 'INPUT' && ['checkbox', 'radio'].includes((target as HTMLInputElement).type.toLowerCase())) { if (target.nodeName === 'INPUT' && ['checkbox', 'radio'].includes((target as HTMLInputElement).type.toLowerCase())) {
return { return {
@ -535,7 +541,7 @@ class TextAssertionTool implements RecorderTool {
name: 'assertValue', name: 'assertValue',
selector, selector,
signals: [], signals: [],
value: (target as HTMLInputElement).value, value: (target as (HTMLInputElement | HTMLSelectElement)).value,
}; };
} }
} else { } else {
@ -612,6 +618,10 @@ class TextAssertionTool implements RecorderTool {
lineNumbers: false, lineNumbers: false,
lineWrapping: true, lineWrapping: true,
}); });
cm.on('keydown', (_, event) => {
if (event.key === 'Tab')
(event as any).codemirrorIgnore = true;
});
cm.on('change', () => { cm.on('change', () => {
if (this._action) { if (this._action) {
const selector = locatorOrSelectorAsSelector(this._recorder.state.language, cm.getValue(), this._recorder.state.testIdAttributeName); const selector = locatorOrSelectorAsSelector(this._recorder.state.language, cm.getValue(), this._recorder.state.testIdAttributeName);