From 6105d8a26a269b80bfff37b3c22b705713f97650 Mon Sep 17 00:00:00 2001 From: Joel Einbinder Date: Tue, 11 Feb 2020 14:15:30 -0800 Subject: [PATCH] fix(tests): fix test that was leaking a context (#933) --- test/browser.spec.js | 1 + test/playwright.spec.js | 1 + 2 files changed, 2 insertions(+) diff --git a/test/browser.spec.js b/test/browser.spec.js index c79494a343..f5e032ef8e 100644 --- a/test/browser.spec.js +++ b/test/browser.spec.js @@ -42,6 +42,7 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE const page = await browser.newPage(); let error; await page.context().newPage().catch(e => error = e); + await page.close(); expect(error.message).toContain('Please use browser.newContext()'); }); }); diff --git a/test/playwright.spec.js b/test/playwright.spec.js index 38590dba63..9385c7c093 100644 --- a/test/playwright.spec.js +++ b/test/playwright.spec.js @@ -118,6 +118,7 @@ module.exports.describe = ({testRunner, product, playwrightPath}) => { state.tearDown = async () => { await Promise.all(contexts.map(c => c.close())); + expect((await state.browser.contexts()).length).toBe(0, `"${test.fullName}" leaked a context`); if (rl) { rl.removeListener('line', onLine); rl.close();