Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: remove stale TODOs (#18331)

Browse source
This commit is contained in:
Yury Semikhatsky 2022-10-25 15:21:04 -07:00 committed by GitHub
parent ffc47271f2
commit 63c41f88cd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/playwright-test/src/runner.ts
View file

@ -265,7 +265,6 @@ export class Runner {
const runStages = collectRunStages(projects); const runStages = collectRunStages(projects);
assert(runStages.length > 0); assert(runStages.length > 0);
for (const stage of runStages) { for (const stage of runStages) {
// TODO: do not collect files for each project multiple times.
const filesByProject = await this._collectFiles(stage, fileMatcherFrom(options.testFileFilters)); const filesByProject = await this._collectFiles(stage, fileMatcherFrom(options.testFileFilters));
const allTestFiles = new Set<string>(); const allTestFiles = new Set<string>();
@ -287,7 +286,6 @@ export class Runner {
fatalErrors.push(duplicateTitlesError); fatalErrors.push(duplicateTitlesError);
// Filter tests to respect line/column filter. // Filter tests to respect line/column filter.
// TODO: figure out how this is supposed to work with groups.
if (options.testFileFilters.length) if (options.testFileFilters.length)
filterByFocusedLine(preprocessRoot, options.testFileFilters); filterByFocusedLine(preprocessRoot, options.testFileFilters);