Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

lint: fixes (#85)

Browse source
This commit is contained in:
Pavel Feldman 2019-11-26 08:19:02 -08:00 committed by GitHub
parent 0db3101013
commit 66d3dd8626
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 32 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
.eslintrc.js
View file

@ -34,7 +34,6 @@ module.exports = {
"markers": ["*"] "markers": ["*"]
}], }],
"eqeqeq": [2], "eqeqeq": [2],
"arrow-body-style": [2, "as-needed"],
"accessor-pairs": [2, { "accessor-pairs": [2, {
"getWithoutSet": false, "getWithoutSet": false,
"setWithoutGet": false "setWithoutGet": false
@ -76,7 +75,11 @@ module.exports = {
// spacing details // spacing details
"space-infix-ops": 2, "space-infix-ops": 2,
"space-in-parens": [2, "never"], "space-in-parens": [2, "never"],
"space-before-function-paren": [2, "never"], "space-before-function-paren": [2, {
"anonymous": "never",
"named": "never",
"asyncArrow": "always"
}],
"no-whitespace-before-property": 2, "no-whitespace-before-property": 2,
"keyword-spacing": [2, { "keyword-spacing": [2, {
"overrides": { "overrides": {

18
src/chromium/JSHandle.ts
View file

@ -153,7 +153,7 @@ export class ElementHandle extends JSHandle {
} }
async _scrollIntoViewIfNeeded() { async _scrollIntoViewIfNeeded() {
const error = await this.evaluate(async(element, pageJavascriptEnabled) => { const error = await this.evaluate(async (element, pageJavascriptEnabled) => {
if (!element.isConnected) if (!element.isConnected)
return 'Node is detached from document'; return 'Node is detached from document';
if (element.nodeType !== Node.ELEMENT_NODE) if (element.nodeType !== Node.ELEMENT_NODE)
@ -407,8 +407,8 @@ export class ElementHandle extends JSHandle {
async $(selector: string): Promise<ElementHandle | null> { async $(selector: string): Promise<ElementHandle | null> {
const handle = await this.evaluateHandle( const handle = await this.evaluateHandle(
(root: SelectorRoot, selector: string, injected: Injected) => injected.querySelector('css=' + selector, root), (root: SelectorRoot, selector: string, injected: Injected) => injected.querySelector('css=' + selector, root),
selector, await this._context._injected() selector, await this._context._injected()
); );
const element = handle.asElement(); const element = handle.asElement();
if (element) if (element)
@ -419,8 +419,8 @@ export class ElementHandle extends JSHandle {
async $$(selector: string): Promise<ElementHandle[]> { async $$(selector: string): Promise<ElementHandle[]> {
const arrayHandle = await this.evaluateHandle( const arrayHandle = await this.evaluateHandle(
(root: SelectorRoot, selector: string, injected: Injected) => injected.querySelectorAll('css=' + selector, root), (root: SelectorRoot, selector: string, injected: Injected) => injected.querySelectorAll('css=' + selector, root),
selector, await this._context._injected() selector, await this._context._injected()
); );
const properties = await arrayHandle.getProperties(); const properties = await arrayHandle.getProperties();
await arrayHandle.dispose(); await arrayHandle.dispose();
@ -444,8 +444,8 @@ export class ElementHandle extends JSHandle {
$$eval: types.$$Eval<JSHandle> = async (selector, pageFunction, ...args) => { $$eval: types.$$Eval<JSHandle> = async (selector, pageFunction, ...args) => {
const arrayHandle = await this.evaluateHandle( const arrayHandle = await this.evaluateHandle(
(root: SelectorRoot, selector: string, injected: Injected) => injected.querySelectorAll('css=' + selector, root), (root: SelectorRoot, selector: string, injected: Injected) => injected.querySelectorAll('css=' + selector, root),
selector, await this._context._injected() selector, await this._context._injected()
); );
const result = await arrayHandle.evaluate(pageFunction, ...args as any); const result = await arrayHandle.evaluate(pageFunction, ...args as any);
@ -455,8 +455,8 @@ export class ElementHandle extends JSHandle {
async $x(expression: string): Promise<ElementHandle[]> { async $x(expression: string): Promise<ElementHandle[]> {
const arrayHandle = await this.evaluateHandle( const arrayHandle = await this.evaluateHandle(
(root: SelectorRoot, expression: string, injected: Injected) => injected.querySelectorAll('xpath=' + expression, root), (root: SelectorRoot, expression: string, injected: Injected) => injected.querySelectorAll('xpath=' + expression, root),
expression, await this._context._injected() expression, await this._context._injected()
); );
const properties = await arrayHandle.getProperties(); const properties = await arrayHandle.getProperties();
await arrayHandle.dispose(); await arrayHandle.dispose();

2
src/chromium/Target.ts
View file

@ -87,7 +87,7 @@ export class Target {
if (!this._workerPromise) { if (!this._workerPromise) {
// TODO(einbinder): Make workers send their console logs. // TODO(einbinder): Make workers send their console logs.
this._workerPromise = this._sessionFactory() this._workerPromise = this._sessionFactory()
.then(client => new Worker(client, this._targetInfo.url, () => { } /* consoleAPICalled */, () => { } /* exceptionThrown */)); .then(client => new Worker(client, this._targetInfo.url, () => { } /* consoleAPICalled */, () => { } /* exceptionThrown */));
} }
return this._workerPromise; return this._workerPromise;
} }

18
src/firefox/JSHandle.ts
View file

@ -208,8 +208,8 @@ export class ElementHandle extends JSHandle {
async $(selector: string): Promise<ElementHandle | null> { async $(selector: string): Promise<ElementHandle | null> {
const handle = await this._frame.evaluateHandle( const handle = await this._frame.evaluateHandle(
(root: SelectorRoot, selector: string, injected: Injected) => injected.querySelector('css=' + selector, root), (root: SelectorRoot, selector: string, injected: Injected) => injected.querySelector('css=' + selector, root),
this, selector, await this._context._injected() this, selector, await this._context._injected()
); );
const element = handle.asElement(); const element = handle.asElement();
if (element) if (element)
@ -220,8 +220,8 @@ export class ElementHandle extends JSHandle {
async $$(selector: string): Promise<ElementHandle[]> { async $$(selector: string): Promise<ElementHandle[]> {
const arrayHandle = await this._frame.evaluateHandle( const arrayHandle = await this._frame.evaluateHandle(
(root: SelectorRoot, selector: string, injected: Injected) => injected.querySelectorAll('css=' + selector, root), (root: SelectorRoot, selector: string, injected: Injected) => injected.querySelectorAll('css=' + selector, root),
this, selector, await this._context._injected() this, selector, await this._context._injected()
); );
const properties = await arrayHandle.getProperties(); const properties = await arrayHandle.getProperties();
await arrayHandle.dispose(); await arrayHandle.dispose();
@ -245,8 +245,8 @@ export class ElementHandle extends JSHandle {
$$eval: types.$$Eval<JSHandle> = async (selector, pageFunction, ...args) => { $$eval: types.$$Eval<JSHandle> = async (selector, pageFunction, ...args) => {
const arrayHandle = await this._frame.evaluateHandle( const arrayHandle = await this._frame.evaluateHandle(
(root: SelectorRoot, selector: string, injected: Injected) => injected.querySelectorAll('css=' + selector, root), (root: SelectorRoot, selector: string, injected: Injected) => injected.querySelectorAll('css=' + selector, root),
this, selector, await this._context._injected() this, selector, await this._context._injected()
); );
const result = await this._frame.evaluate(pageFunction, arrayHandle, ...args); const result = await this._frame.evaluate(pageFunction, arrayHandle, ...args);
@ -256,8 +256,8 @@ export class ElementHandle extends JSHandle {
async $x(expression: string): Promise<Array<ElementHandle>> { async $x(expression: string): Promise<Array<ElementHandle>> {
const arrayHandle = await this._frame.evaluateHandle( const arrayHandle = await this._frame.evaluateHandle(
(root: SelectorRoot, expression: string, injected: Injected) => injected.querySelectorAll('xpath=' + expression, root), (root: SelectorRoot, expression: string, injected: Injected) => injected.querySelectorAll('xpath=' + expression, root),
this, expression, await this._context._injected() this, expression, await this._context._injected()
); );
const properties = await arrayHandle.getProperties(); const properties = await arrayHandle.getProperties();
await arrayHandle.dispose(); await arrayHandle.dispose();
@ -326,7 +326,7 @@ export class ElementHandle extends JSHandle {
} }
await this.evaluate(async (element: HTMLInputElement, payloads: FilePayload[]) => { await this.evaluate(async (element: HTMLInputElement, payloads: FilePayload[]) => {
const files = await Promise.all(payloads.map(async (file: FilePayload) => { const files = await Promise.all(payloads.map(async (file: FilePayload) => {
const result = await fetch(`data:${file.mimeType};base64,${file.data}`) const result = await fetch(`data:${file.mimeType};base64,${file.data}`);
return new File([await result.blob()], file.name); return new File([await result.blob()], file.name);
})); }));
const dt = new DataTransfer(); const dt = new DataTransfer();

2
src/helper.ts
View file

@ -45,7 +45,7 @@ class Helper {
const method = Reflect.get(classType.prototype, methodName); const method = Reflect.get(classType.prototype, methodName);
if (methodName === 'constructor' || typeof methodName !== 'string' || methodName.startsWith('_') || typeof method !== 'function' || method.constructor.name !== 'AsyncFunction') if (methodName === 'constructor' || typeof methodName !== 'string' || methodName.startsWith('_') || typeof method !== 'function' || method.constructor.name !== 'AsyncFunction')
continue; continue;
Reflect.set(classType.prototype, methodName, function(...args) { Reflect.set(classType.prototype, methodName, function(...args: any[]) {
const syncStack: any = {}; const syncStack: any = {};
Error.captureStackTrace(syncStack); Error.captureStackTrace(syncStack);
return method.call(this, ...args).catch(e => { return method.call(this, ...args).catch(e => {

14
src/webkit/JSHandle.ts
View file

@ -142,7 +142,7 @@ export class ElementHandle extends JSHandle {
} }
async _scrollIntoViewIfNeeded() { async _scrollIntoViewIfNeeded() {
const error = await this.evaluate(async(element, pageJavascriptEnabled) => { const error = await this.evaluate(async (element, pageJavascriptEnabled) => {
if (!element.isConnected) if (!element.isConnected)
return 'Node is detached from document'; return 'Node is detached from document';
if (element.nodeType !== Node.ELEMENT_NODE) if (element.nodeType !== Node.ELEMENT_NODE)
@ -287,8 +287,8 @@ export class ElementHandle extends JSHandle {
async $(selector: string): Promise<ElementHandle | null> { async $(selector: string): Promise<ElementHandle | null> {
const handle = await this.evaluateHandle( const handle = await this.evaluateHandle(
(root: SelectorRoot, selector: string, injected: Injected) => injected.querySelector('css=' + selector, root), (root: SelectorRoot, selector: string, injected: Injected) => injected.querySelector('css=' + selector, root),
selector, await this._context._injected() selector, await this._context._injected()
); );
const element = handle.asElement(); const element = handle.asElement();
if (element) if (element)
@ -324,8 +324,8 @@ export class ElementHandle extends JSHandle {
$$eval: types.$$Eval<JSHandle> = async (selector, pageFunction, ...args) => { $$eval: types.$$Eval<JSHandle> = async (selector, pageFunction, ...args) => {
const arrayHandle = await this.evaluateHandle( const arrayHandle = await this.evaluateHandle(
(root: SelectorRoot, selector: string, injected: Injected) => injected.querySelectorAll('css=' + selector, root), (root: SelectorRoot, selector: string, injected: Injected) => injected.querySelectorAll('css=' + selector, root),
selector, await this._context._injected() selector, await this._context._injected()
); );
const result = await arrayHandle.evaluate(pageFunction, ...args as any); const result = await arrayHandle.evaluate(pageFunction, ...args as any);
@ -335,8 +335,8 @@ export class ElementHandle extends JSHandle {
async $x(expression: string): Promise<ElementHandle[]> { async $x(expression: string): Promise<ElementHandle[]> {
const arrayHandle = await this.evaluateHandle( const arrayHandle = await this.evaluateHandle(
(root: SelectorRoot, expression: string, injected: Injected) => injected.querySelectorAll('xpath=' + expression, root), (root: SelectorRoot, expression: string, injected: Injected) => injected.querySelectorAll('xpath=' + expression, root),
expression, await this._context._injected() expression, await this._context._injected()
); );
const properties = await arrayHandle.getProperties(); const properties = await arrayHandle.getProperties();
await arrayHandle.dispose(); await arrayHandle.dispose();