Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

remove superfluous class field

Browse source
This commit is contained in:
Simon Knott 2024-07-25 15:39:44 +02:00
parent 742ae72fed
commit 6744d03262
No known key found for this signature in database
GPG key ID: 8CEDC00028084AEC
2 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/trace-viewer/src/ui/metadataView.tsx
View file

@ -33,10 +33,10 @@ export const MetadataView: React.FunctionComponent<{
{model.channel && <div className='call-line'>channel:<span className='call-value string' title={model.channel}>{model.channel}</span></div>}
{model.platform && <div className='call-line'>platform:<span className='call-value string' title={model.platform}>{model.platform}</span></div>}
{model.options.userAgent && <div className='call-line'>user agent:<span className='call-value datetime' title={model.options.userAgent}>{model.options.userAgent}</span></div>}
{model.baseURL && (
{model.options.baseURL && (
<>
<div className='call-section' style={{ paddingTop: 2 }}>Config</div>
<div className='call-line'>baseURL:<a className='call-value string' href={model.baseURL} title={model.baseURL} target='_blank' rel='noopener noreferrer'>{model.baseURL}</a></div>
<div className='call-line'>baseURL:<a className='call-value string' href={model.options.baseURL} title={model.options.baseURL} target='_blank' rel='noopener noreferrer'>{model.options.baseURL}</a></div>
</>
)}
<div className='call-section'>Viewport</div>

2
packages/trace-viewer/src/ui/modelUtil.ts
View file

@ -59,7 +59,6 @@ export class MultiTraceModel {
readonly startTime: number;
readonly endTime: number;
readonly browserName: string;
readonly baseURL?: string;
readonly channel?: string;
readonly platform?: string;
readonly wallTime?: number;
@ -84,7 +83,6 @@ export class MultiTraceModel {
const libraryContext = contexts.find(context => context.origin === 'library');
this.browserName = libraryContext?.browserName || '';
this.baseURL = libraryContext?.options.baseURL;
this.sdkLanguage = libraryContext?.sdkLanguage;
this.channel = libraryContext?.channel;
this.testIdAttributeName = libraryContext?.testIdAttributeName;