From 6822d03f0b337e18d875d5b67991096923848d87 Mon Sep 17 00:00:00 2001 From: Dmitry Gozman Date: Thu, 9 Jun 2022 21:07:57 -0700 Subject: [PATCH] fix(cli): default to no timeout (#14769) --- packages/playwright-core/src/cli/cli.ts | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/packages/playwright-core/src/cli/cli.ts b/packages/playwright-core/src/cli/cli.ts index 81d578a19d..ffeb305af2 100755 --- a/packages/playwright-core/src/cli/cli.ts +++ b/packages/playwright-core/src/cli/cli.ts @@ -499,10 +499,9 @@ async function launchContext(options: Options, headless: boolean, executablePath closeBrowser().catch(e => null); }); }); - if (options.timeout) { - context.setDefaultTimeout(parseInt(options.timeout, 10)); - context.setDefaultNavigationTimeout(parseInt(options.timeout, 10)); - } + const timeout = options.timeout ? parseInt(options.timeout, 10) : 0; + context.setDefaultTimeout(timeout); + context.setDefaultNavigationTimeout(timeout); if (options.saveTrace) await context.tracing.start({ screenshots: true, snapshots: true }); @@ -654,7 +653,7 @@ function commandWithOpenOptions(command: string, description: string, options: a .option('--save-storage ', 'save context storage state at the end, for later use with --load-storage') .option('--save-trace ', 'record a trace for the session and save it to a file') .option('--timezone