Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

remove special handling of merged test ids

Browse source
This commit is contained in:
Mathias Leppich 2024-05-29 11:28:16 +02:00
parent 389e5711f4
commit 6884fd715f
1 changed files with 2 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
packages/playwright/src/reporters/lastrun.ts
View file

@ -25,11 +25,6 @@ type LastRunOptions = {
_mode: 'list' | 'test' | 'merge', _mode: 'list' | 'test' | 'merge',
}; };
// The blob reporter adds a suffix to test ids to avoid collisions. But we need
// to remove that suffix to match the test ids from the last run.
function unsaltTestId(testId: string): string {
return testId.split('-').map(s => s.substring(0, 20)).join('-');
}
class LastRunReporter extends BaseReporter { class LastRunReporter extends BaseReporter {
@ -40,12 +35,10 @@ class LastRunReporter extends BaseReporter {
}; };
private resolvedOutputFile: string | undefined; private resolvedOutputFile: string | undefined;
private testId: (testId: string) => string;
constructor(options: LastRunOptions) { constructor(options: LastRunOptions) {
super(); super();
this.resolvedOutputFile = resolveOutputFile('LASTRUN', { fileName: '.last-run.json', ...options })?.outputFile; this.resolvedOutputFile = resolveOutputFile('LASTRUN', { fileName: '.last-run.json', ...options })?.outputFile;
this.testId = options._mode === 'merge' ? unsaltTestId : (testId: string) => testId;
} }
override printsToStdio() { override printsToStdio() {
@ -54,9 +47,9 @@ class LastRunReporter extends BaseReporter {
override onTestEnd(test: TestCase, result: TestResult): void { override onTestEnd(test: TestCase, result: TestResult): void {
super.onTestEnd(test, result); super.onTestEnd(test, result);
this.lastRun.testDurations![this.testId(test.id)] = result.duration; this.lastRun.testDurations![test.id] = result.duration;
if (result.status === 'failed') if (result.status === 'failed')
this.lastRun.failedTests.push(this.testId(test.id)); this.lastRun.failedTests.push(test.id);
} }
override async onEnd(result: FullResult) { override async onEnd(result: FullResult) {