Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: add fixme's (#20826)

Browse source 
Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Max Schmitt <max@schmitt.mx>
This commit is contained in:
Pavel Feldman 2023-02-10 10:54:00 -08:00 committed by GitHub
parent 1ba768bf60
commit 6920a82f50
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
tests/library/browsercontext-proxy.spec.ts
View file

@ -210,7 +210,8 @@ it('should use proxy for second page', async ({ contextFactory, server, proxySer
await context.close(); await context.close();
}); });
it('should use proxy for https urls', async ({ contextFactory, server, httpsServer, proxyServer }) => { it('should use proxy for https urls', async ({ contextFactory, httpsServer, proxyServer, isWindows, browserName }) => {
it.fixme(browserName === 'webkit' && isWindows, 'Fixed upstream, https://github.com/microsoft/playwright/issues/20822');
httpsServer.setRoute('/target.html', async (req, res) => { httpsServer.setRoute('/target.html', async (req, res) => {
res.end('<html><title>Served by https server via proxy</title></html>'); res.end('<html><title>Served by https server via proxy</title></html>');
}); });

3
tests/page/page-click.spec.ts
View file

@ -1075,8 +1075,7 @@ it('ensure events are dispatched in the individual tasks', async ({ page, browse
// Click on the inner div element // Click on the inner div element
await page.locator('#inner').click(); await page.locator('#inner').click();
// await new Promise(() => {}); await expect.poll(() => messages).toEqual([
expect(messages).toEqual([
'click inner', 'click inner',
'promise inner', 'promise inner',
'click outer', 'click outer',

3
tests/page/page-drag.spec.ts
View file

@ -67,7 +67,8 @@ it.describe('Drag and drop', () => {
]); ]);
}); });
it('should work inside iframe', async ({ page, server, browserName }) => { it('should work inside iframe', async ({ page, server, browserName, isElectron, isWindows }) => {
it.fixme(isElectron && isWindows, 'Fails on the bots');
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
const frame = await attachFrame(page, 'myframe', server.PREFIX + '/drag-n-drop.html'); const frame = await attachFrame(page, 'myframe', server.PREFIX + '/drag-n-drop.html');
await page.$eval('iframe', iframe => { await page.$eval('iframe', iframe => {

3
tests/page/page-screenshot.spec.ts
View file

@ -268,8 +268,9 @@ it.describe('page screenshot', () => {
expect(screenshot).toMatchSnapshot('screenshot-clip-odd-size.png'); expect(screenshot).toMatchSnapshot('screenshot-clip-odd-size.png');
}); });
it('should work for canvas', async ({ page, server, browserName, channel, browserMajorVersion }) => { it('should work for canvas', async ({ page, server, browserName, channel, browserMajorVersion, isElectron, isMac }) => {
it.fixme(browserName === 'firefox' && channel === 'firefox-beta' && browserMajorVersion === 110, 'https://github.com/microsoft/playwright/issues/20522'); it.fixme(browserName === 'firefox' && channel === 'firefox-beta' && browserMajorVersion === 110, 'https://github.com/microsoft/playwright/issues/20522');
it.fixme(isElectron && isMac, 'Fails on the bots');
await page.setViewportSize({ width: 500, height: 500 }); await page.setViewportSize({ width: 500, height: 500 });
await page.goto(server.PREFIX + '/screenshots/canvas.html'); await page.goto(server.PREFIX + '/screenshots/canvas.html');
const screenshot = await page.screenshot(); const screenshot = await page.screenshot();