From 6a39b866403dc65c748472d5e46328599f41016a Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Thu, 13 May 2021 11:57:02 -0700 Subject: [PATCH] chore: GoToAsync -> GotoAsync (#6563) --- docs/src/api/class-browser.md | 4 ++-- docs/src/api/class-browsercontext.md | 6 +++--- docs/src/api/class-elementhandle.md | 2 +- docs/src/api/class-frame.md | 4 ++-- docs/src/api/class-keyboard.md | 2 +- docs/src/api/class-page.md | 12 ++++++------ docs/src/api/class-playwright.md | 4 ++-- docs/src/api/class-request.md | 6 +++--- docs/src/intro-csharp.md | 2 +- src/server/supplements/recorder/csharp.ts | 4 ++-- tests/inspector/cli-codegen-2.spec.ts | 2 +- 11 files changed, 24 insertions(+), 24 deletions(-) diff --git a/docs/src/api/class-browser.md b/docs/src/api/class-browser.md index 281f01ee42..6a5064b172 100644 --- a/docs/src/api/class-browser.md +++ b/docs/src/api/class-browser.md @@ -73,7 +73,7 @@ class BrowserExamples var firefox = playwright.Firefox; var browser = await firefox.LaunchAsync(headless: false); var page = await browser.NewPageAsync(); - await page.GoToAsync("https://www.bing.com"); + await page.GotoAsync("https://www.bing.com"); await browser.CloseAsync(); } } @@ -203,7 +203,7 @@ var browser = await playwright.Firefox.LaunchAsync(); var context = await browser.NewContextAsync(); // Create a new page in a pristine context. var page = await context.NewPageAsync(); ; -await page.GoToAsync("https://www.bing.com"); +await page.GotoAsync("https://www.bing.com"); ``` ### option: Browser.newContext.-inline- = %%-shared-context-params-list-%% diff --git a/docs/src/api/class-browsercontext.md b/docs/src/api/class-browsercontext.md index 1a04c554df..f4506b4c1c 100644 --- a/docs/src/api/class-browsercontext.md +++ b/docs/src/api/class-browsercontext.md @@ -56,7 +56,7 @@ var browser = await playwright.Firefox.LaunchAsync(headless: false); var context = await browser.NewContextAsync(); // Create a new page inside context. var page = await context.NewPageAsync(); -await page.GoToAsync("https://bing.com"); +await page.GotoAsync("https://bing.com"); // Dispose context once it"s no longer needed. await context.CloseAsync(); ``` @@ -895,7 +895,7 @@ browser.close() var context = await browser.NewContextAsync(); var page = await context.NewPageAsync(); await context.RouteAsync("**/*.{png,jpg,jpeg}", r => r.AbortAsync()); -await page.GoToAsync("https://theverge.com"); +await page.GotoAsync("https://theverge.com"); await browser.CloseAsync(); ``` @@ -940,7 +940,7 @@ browser.close() var context = await browser.NewContextAsync(); var page = await context.NewPageAsync(); await context.RouteAsync(new Regex("(\\.png$)|(\\.jpg$)"), r => r.AbortAsync()); -await page.GoToAsync("https://theverge.com"); +await page.GotoAsync("https://theverge.com"); await browser.CloseAsync(); ``` diff --git a/docs/src/api/class-elementhandle.md b/docs/src/api/class-elementhandle.md index ed33acd55d..c27cebc977 100644 --- a/docs/src/api/class-elementhandle.md +++ b/docs/src/api/class-elementhandle.md @@ -80,7 +80,7 @@ class HandleExamples using var playwright = await Playwright.CreateAsync(); var browser = await playwright.Chromium.LaunchAsync(headless: false); var page = await browser.NewPageAsync(); - await page.GoToAsync("https://www.bing.com"); + await page.GotoAsync("https://www.bing.com"); var handle = await page.QuerySelectorAsync("a"); await handle.ClickAsync(); } diff --git a/docs/src/api/class-frame.md b/docs/src/api/class-frame.md index a5baf5561b..958ba79040 100644 --- a/docs/src/api/class-frame.md +++ b/docs/src/api/class-frame.md @@ -110,7 +110,7 @@ class FrameExamples await using var browser = await playwright.Firefox.LaunchAsync(); var page = await browser.NewPageAsync(); - await page.GoToAsync("https://www.bing.com"); + await page.GotoAsync("https://www.bing.com"); DumpFrameTree(page.MainFrame, string.Empty); } @@ -1540,7 +1540,7 @@ class FrameExamples foreach (var currentUrl in new[] { "https://www.google.com", "https://bbc.com" }) { - await page.GoToAsync(currentUrl); + await page.GotoAsync(currentUrl); element = await page.MainFrame.WaitForSelectorAsync("img"); Console.WriteLine($"Loaded image: {await element.GetAttributeAsync("src")}"); } diff --git a/docs/src/api/class-keyboard.md b/docs/src/api/class-keyboard.md index ab2e6e6c03..4b2514f2a2 100644 --- a/docs/src/api/class-keyboard.md +++ b/docs/src/api/class-keyboard.md @@ -274,7 +274,7 @@ browser.close() ``` ```csharp -await page.GoToAsync("https://keycode.info"); +await page.GotoAsync("https://keycode.info"); await page.Keyboard.PressAsync("A"); await page.ScreenshotAsync("A.png"); await page.Keyboard.PressAsync("ArrowLeft"); diff --git a/docs/src/api/class-page.md b/docs/src/api/class-page.md index 3be771c119..205a7eef83 100644 --- a/docs/src/api/class-page.md +++ b/docs/src/api/class-page.md @@ -84,7 +84,7 @@ class PageExamples using var playwright = await Playwright.CreateAsync(); await using var browser = await playwright.Webkit.LaunchAsync(); var page = await browser.NewPageAsync(); - await page.GoToAsync("https://www.theverge.com"); + await page.GotoAsync("https://www.theverge.com"); await page.ScreenshotAsync("theverge.png"); } } @@ -2266,7 +2266,7 @@ browser.close() ```csharp await using var browser = await playwright.Webkit.LaunchAsync(headless: false); var page = await browser.NewPageAsync(); -await page.GoToAsync("https://keycode.info"); +await page.GotoAsync("https://keycode.info"); await page.PressAsync("body", "A"); await page.ScreenshotAsync("A.png"); await page.PressAsync("body", "ArrowLeft"); @@ -2371,7 +2371,7 @@ browser.close() await using var browser = await playwright.Webkit.LaunchAsync(); var page = await browser.NewPageAsync(); await page.RouteAsync("**/*.{png,jpg,jpeg}", async r => await r.AbortAsync()); -await page.GoToAsync("https://www.microsoft.com"); +await page.GotoAsync("https://www.microsoft.com"); ``` or the same snippet using a regex pattern instead: @@ -2408,7 +2408,7 @@ browser.close() await using var browser = await playwright.Webkit.LaunchAsync(); var page = await browser.NewPageAsync(); await page.RouteAsync(new Regex("(\\.png$)|(\\.jpg$)"), async r => await r.AbortAsync()); -await page.GoToAsync("https://www.microsoft.com"); +await page.GotoAsync("https://www.microsoft.com"); ``` It is possible to examine the request to decide the route action. For example, mocking all requests that contain some post data, and leaving all other requests as is: @@ -2708,7 +2708,7 @@ page.goto("https://example.com") ```csharp var page = await browser.NewPageAsync(); await page.SetViewportSizeAsync(640, 480); -await page.GoToAsync("https://www.microsoft.com"); +await page.GotoAsync("https://www.microsoft.com"); ``` ### param: Page.setViewportSize.viewportSize @@ -3565,7 +3565,7 @@ class FrameExamples foreach (var currentUrl in new[] { "https://www.google.com", "https://bbc.com" }) { - await page.GoToAsync(currentUrl); + await page.GotoAsync(currentUrl); var element = await page.WaitForSelectorAsync("img"); Console.WriteLine($"Loaded image: {await element.GetAttributeAsync("src")}"); } diff --git a/docs/src/api/class-playwright.md b/docs/src/api/class-playwright.md index 2533ddf910..46ba29cbd5 100644 --- a/docs/src/api/class-playwright.md +++ b/docs/src/api/class-playwright.md @@ -77,7 +77,7 @@ class PlaywrightExample await using var browser = await playwright.Chromium.LaunchAsync(); var page = await browser.NewPageAsync(); - await page.GoToAsync("https://www.microsoft.com"); + await page.GotoAsync("https://www.microsoft.com"); // other actions... } } @@ -166,7 +166,7 @@ class PlaywrightExample await using var context = await browser.NewContextAsync(Playwright.Devices["iPhone 6"]); var page = await context.NewPageAsync(); - await page.GoToAsync("https://www.theverge.com"); + await page.GotoAsync("https://www.theverge.com"); // other actions... } } diff --git a/docs/src/api/class-request.md b/docs/src/api/class-request.md index dd22051e35..be29a5a69e 100644 --- a/docs/src/api/class-request.md +++ b/docs/src/api/class-request.md @@ -117,7 +117,7 @@ print(response.request.redirected_from.url) # "http://example.com" ``` ```csharp -var response = await page.GoToAsync("http://www.microsoft.com"); +var response = await page.GotoAsync("http://www.microsoft.com"); Console.WriteLine(response.Request.RedirectedFrom?.Url); // http://www.microsoft.com ``` @@ -144,7 +144,7 @@ print(response.request.redirected_from) # None ``` ```csharp -var response = await page.GoToAsync("https://www.google.com"); +var response = await page.GotoAsync("https://www.google.com"); Console.WriteLine(response.Request.RedirectedFrom?.Url); // null ``` @@ -240,7 +240,7 @@ print(request.timing) ```csharp var requestFinishedTask = page.WaitForEventAsync(PageEvent.RequestFinished); -await Task.WhenAll(requestFinishedTask, page.GoToAsync("https://www.microsoft.com")); +await Task.WhenAll(requestFinishedTask, page.GotoAsync("https://www.microsoft.com")); Console.WriteLine(requestFinishedTask.Result.Timing.ResponseEnd); ``` diff --git a/docs/src/intro-csharp.md b/docs/src/intro-csharp.md index 8746c6a0b9..5eb337a43d 100644 --- a/docs/src/intro-csharp.md +++ b/docs/src/intro-csharp.md @@ -20,7 +20,7 @@ dotnet add package PlaywrightSharp using var playwright = await Playwright.CreateAsync(); await using var browser = await playwright.Chromium.LaunchAsync(); var page = await browser.NewPageAsync(); -await page.GoToAsync("http://www.bing.com"); +await page.GotoAsync("http://www.bing.com"); await page.ScreenshotAsync(path: outputFile); ``` diff --git a/src/server/supplements/recorder/csharp.ts b/src/server/supplements/recorder/csharp.ts index 58e8954762..f8265ce2a3 100644 --- a/src/server/supplements/recorder/csharp.ts +++ b/src/server/supplements/recorder/csharp.ts @@ -35,7 +35,7 @@ export class CSharpLanguageGenerator implements LanguageGenerator { if (action.name === 'openPage') { formatter.add(`var ${pageAlias} = await context.NewPageAsync();`); if (action.url && action.url !== 'about:blank' && action.url !== 'chrome://newtab/') - formatter.add(`await ${pageAlias}.GoToAsync(${quote(action.url)});`); + formatter.add(`await ${pageAlias}.GotoAsync(${quote(action.url)});`); return formatter.format(); } @@ -123,7 +123,7 @@ export class CSharpLanguageGenerator implements LanguageGenerator { return `PressAsync(${quote(action.selector)}, ${quote(shortcut)})`; } case 'navigate': - return `GoToAsync(${quote(action.url)})`; + return `GotoAsync(${quote(action.url)})`; case 'select': return `SelectOptionAsync(${quote(action.selector)}, ${formatObject(action.options.length > 1 ? action.options : action.options[0])})`; } diff --git a/tests/inspector/cli-codegen-2.spec.ts b/tests/inspector/cli-codegen-2.spec.ts index ac14f52c6d..f61421f989 100644 --- a/tests/inspector/cli-codegen-2.spec.ts +++ b/tests/inspector/cli-codegen-2.spec.ts @@ -377,7 +377,7 @@ await page.ClickAsync(\"text=click me\");`); expect(sources.get('').text).toContain(` // Open new page var page1 = await context.NewPageAsync(); -await page1.GoToAsync("about:blank?foo");`); +await page1.GotoAsync("about:blank?foo");`); } else if (browserName === 'firefox') { expect(sources.get('').text).toContain(` // Click text=link