From 6a7bfe63a1d3df5352e3ac5f3808a2f35b898bcd Mon Sep 17 00:00:00 2001 From: Playwright Service <89237858+playwrightmachine@users.noreply.github.com> Date: Wed, 12 Jun 2024 07:06:47 -0700 Subject: [PATCH] feat(webkit): roll to r2031 (#31272) --- packages/playwright-core/browsers.json | 2 +- packages/playwright-core/src/server/webkit/wkPage.ts | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/playwright-core/browsers.json b/packages/playwright-core/browsers.json index 5234f96102..a45f862d15 100644 --- a/packages/playwright-core/browsers.json +++ b/packages/playwright-core/browsers.json @@ -27,7 +27,7 @@ }, { "name": "webkit", - "revision": "2029", + "revision": "2031", "installByDefault": true, "revisionOverrides": { "mac10.14": "1446", diff --git a/packages/playwright-core/src/server/webkit/wkPage.ts b/packages/playwright-core/src/server/webkit/wkPage.ts index 8d441240bc..a495244b6b 100644 --- a/packages/playwright-core/src/server/webkit/wkPage.ts +++ b/packages/playwright-core/src/server/webkit/wkPage.ts @@ -716,7 +716,10 @@ export class WKPage implements PageDelegate { const angle = viewportSize.width > viewportSize.height ? 90 : 0; // Special handling for macOS 12. const useLegacySetOrientationOverrideMethod = os.platform() === 'darwin' && parseInt(os.release().split('.')[0], 10) <= 21; - promises.push(this._pageProxySession.send(useLegacySetOrientationOverrideMethod ? 'Page.setOrientationOverride' as any : 'Emulation.setOrientationOverride', { angle })); + if (useLegacySetOrientationOverrideMethod) + promises.push(this._session.send('Page.setOrientationOverride' as any, { angle })); + else + promises.push(this._pageProxySession.send('Emulation.setOrientationOverride', { angle })); } await Promise.all(promises); }