From 6a9939db865ee0387c8285df2d2bc8b5fdc29b39 Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Tue, 18 May 2021 02:14:46 -0700 Subject: [PATCH] fix(release-1.11): fix tests after cherry-pick (#6634) --- tests/chromium/chromium.spec.ts | 51 +++++++++++++++++---------------- 1 file changed, 26 insertions(+), 25 deletions(-) diff --git a/tests/chromium/chromium.spec.ts b/tests/chromium/chromium.spec.ts index 8d0cc8ce20..ff1a4fa934 100644 --- a/tests/chromium/chromium.spec.ts +++ b/tests/chromium/chromium.spec.ts @@ -245,31 +245,32 @@ playwrightTest.describe('chromium', () => { expect(request.headers['foo']).toBe('bar'); } }); -}); -playwrightTest('should report all pages in an existing browser', async ({ browserType, browserOptions }, testInfo) => { - const port = 9339 + testInfo.workerIndex; - const browserServer = await browserType.launch({ - ...browserOptions, - args: ['--remote-debugging-port=' + port] + playwrightTest('should report all pages in an existing browser', async ({ browserType, browserOptions }, testInfo) => { + const port = 9339 + testInfo.workerIndex; + const browserServer = await browserType.launch({ + ...browserOptions, + args: ['--remote-debugging-port=' + port] + }); + try { + const cdpBrowser = await browserType.connectOverCDP({ + endpointURL: `http://localhost:${port}/`, + }); + const contexts = cdpBrowser.contexts(); + expect(contexts.length).toBe(1); + for (let i = 0; i < 3; i++) + await contexts[0].newPage(); + await cdpBrowser.close(); + + const cdpBrowser2 = await browserType.connectOverCDP({ + endpointURL: `http://localhost:${port}/`, + }); + expect(cdpBrowser2.contexts()[0].pages().length).toBe(3); + + await cdpBrowser2.close(); + } finally { + await browserServer.close(); + } }); - try { - const cdpBrowser = await browserType.connectOverCDP({ - endpointURL: `http://localhost:${port}/`, - }); - const contexts = cdpBrowser.contexts(); - expect(contexts.length).toBe(1); - for (let i = 0; i < 3; i++) - await contexts[0].newPage(); - await cdpBrowser.close(); - - const cdpBrowser2 = await browserType.connectOverCDP({ - endpointURL: `http://localhost:${port}/`, - }); - expect(cdpBrowser2.contexts()[0].pages().length).toBe(3); - - await cdpBrowser2.close(); - } finally { - await browserServer.close(); - } }); +