Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

browser(firefox): create new window for each new page (#2823)

Browse source
This commit is contained in:
Yury Semikhatsky 2020-07-02 14:46:57 -07:00 committed by GitHub
parent b1b6d3f531
commit 6aef045fd4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 44 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
browser_patches/firefox/BUILD_NUMBER
View file

@ -1,2 +1,2 @@
1121 1122
Changed: lushnikov@chromium.org Wed Jul 2 12:02:52 PDT 2020 Changed: yurys@chromium.org Thu Jul 2 14:18:12 PDT 2020

67
browser_patches/firefox/juggler/TargetRegistry.js
View file

@ -257,38 +257,55 @@ class TargetRegistry {
} }
async newPage({browserContextId}) { async newPage({browserContextId}) {
let window;
let created = false;
const windowsIt = Services.wm.getEnumerator('navigator:browser');
if (windowsIt.hasMoreElements()) {
window = windowsIt.getNext();
} else {
const features = "chrome,dialog=no,all";
const args = Cc["@mozilla.org/supports-string;1"].createInstance(Ci.nsISupportsString);
args.data = 'about:blank';
window = Services.ww.openWindow(null, AppConstants.BROWSER_CHROME_URL, '_blank', features, args);
created = true;
}
await waitForWindowReady(window);
const browserContext = this.browserContextForId(browserContextId); const browserContext = this.browserContextForId(browserContextId);
const tab = window.gBrowser.addTab('about:blank', { const features = "chrome,dialog=no,all";
userContextId: browserContext.userContextId, // See _callWithURIToLoad in browser.js for the structure of window.arguments
triggeringPrincipal: Services.scriptSecurityManager.getSystemPrincipal(), // window.arguments[1]: unused (bug 871161)
}); // [2]: referrerInfo (nsIReferrerInfo)
const target = await new Promise(fulfill => { // [3]: postData (nsIInputStream)
// [4]: allowThirdPartyFixup (bool)
// [5]: userContextId (int)
// [6]: originPrincipal (nsIPrincipal)
// [7]: originStoragePrincipal (nsIPrincipal)
// [8]: triggeringPrincipal (nsIPrincipal)
// [9]: allowInheritPrincipal (bool)
// [10]: csp (nsIContentSecurityPolicy)
// [11]: nsOpenWindowInfo
const args = Cc["@mozilla.org/array;1"].createInstance(Ci.nsIMutableArray);
const urlSupports = Cc["@mozilla.org/supports-string;1"].createInstance(
Ci.nsISupportsString
);
urlSupports.data = 'about:blank';
args.appendElement(urlSupports); // 0
args.appendElement(undefined); // 1
args.appendElement(undefined); // 2
args.appendElement(undefined); // 3
args.appendElement(undefined); // 4
const userContextIdSupports = Cc[
"@mozilla.org/supports-PRUint32;1"
].createInstance(Ci.nsISupportsPRUint32);
userContextIdSupports.data = browserContext.userContextId;
args.appendElement(userContextIdSupports); // 5
args.appendElement(undefined); // 6
args.appendElement(undefined); // 7
args.appendElement(Services.scriptSecurityManager.getSystemPrincipal()); // 8
const window = Services.ww.openWindow(null, AppConstants.BROWSER_CHROME_URL, '_blank', features, args);
await waitForWindowReady(window);
if (window.gBrowser.browsers.length !== 1)
throw new Error(`Unexpcted number of tabs in the new window: ${window.gBrowser.browsers.length}`);
const browser = window.gBrowser.browsers[0];
const target = this._browserToTarget.get(browser) || await new Promise(fulfill => {
const listener = helper.on(this, TargetRegistry.Events.TargetCreated, ({target}) => { const listener = helper.on(this, TargetRegistry.Events.TargetCreated, ({target}) => {
if (target._tab === tab) { if (target._linkedBrowser === browser) {
helper.removeListeners([listener]); helper.removeListeners([listener]);
fulfill(target); fulfill(target);
} }
}); });
}); });
if (created) { if (browserContext && browserContext.defaultViewportSize)
window.gBrowser.removeTab(window.gBrowser.getTabForBrowser(window.gBrowser.getBrowserAtIndex(0)), { setViewportSizeForBrowser(browserContext.defaultViewportSize, browser);
skipPermitUnload: true, browser.focus();
});
}
window.gBrowser.selectedTab = tab;
if (browserContext.settings.timezoneId) { if (browserContext.settings.timezoneId) {
if (await target.hasFailedToOverrideTimezone()) if (await target.hasFailedToOverrideTimezone())
throw new Error('Failed to override timezone'); throw new Error('Failed to override timezone');