Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: fix randomly crashing build-playwright-driver.sh (#4909)

Browse source 
Some googling showed that CI systems might not be capable of
handling too much STDOUT that `tar -v` produces.
([source](https://stackoverflow.com/questions/37540792/jenkins-script-tar-write-error)).

This patch:
- removes verbose flag from tar to reduce output
- sets `+x` to get some logging for the script
- silences zip output
This commit is contained in:
Andrey Lushnikov 2021-01-06 14:13:01 +03:00 committed by GitHub
parent 9bbabaaa74
commit 6b3dcb01aa
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
utils/build/build-playwright-driver.sh
View file

@ -1,6 +1,6 @@
#!/bin/bash #!/bin/bash
set -e set -e
set +x set -x
trap "cd $(pwd -P)" EXIT trap "cd $(pwd -P)" EXIT
SCRIPT_PATH="$(cd "$(dirname "$0")" ; pwd -P)" SCRIPT_PATH="$(cd "$(dirname "$0")" ; pwd -P)"
@ -25,18 +25,18 @@ function build {
cd ${SCRIPT_PATH} cd ${SCRIPT_PATH}
mkdir -p ./output/playwright-${SUFFIX} mkdir -p ./output/playwright-${SUFFIX}
tar -xzvf ./output/playwright.tgz -C ./output/playwright-${SUFFIX}/ tar -xzf ./output/playwright.tgz -C ./output/playwright-${SUFFIX}/
curl ${NODE_URL} -o ./output/${NODE_DIR}.${ARCHIVE} curl ${NODE_URL} -o ./output/${NODE_DIR}.${ARCHIVE}
NPM_PATH="" NPM_PATH=""
if [[ "${ARCHIVE}" == "zip" ]]; then if [[ "${ARCHIVE}" == "zip" ]]; then
cd ./output cd ./output
unzip ./${NODE_DIR}.zip unzip -q ./${NODE_DIR}.zip
cd .. cd ..
cp ./output/${NODE_DIR}/node.exe ./output/playwright-${SUFFIX}/ cp ./output/${NODE_DIR}/node.exe ./output/playwright-${SUFFIX}/
NPM_PATH="node_modules/npm/bin/npm-cli.js" NPM_PATH="node_modules/npm/bin/npm-cli.js"
elif [[ "${ARCHIVE}" == "tar.gz" ]]; then elif [[ "${ARCHIVE}" == "tar.gz" ]]; then
tar -xzvf ./output/${NODE_DIR}.tar.gz -C ./output/ tar -xzf ./output/${NODE_DIR}.tar.gz -C ./output/
cp ./output/${NODE_DIR}/bin/node ./output/playwright-${SUFFIX}/ cp ./output/${NODE_DIR}/bin/node ./output/playwright-${SUFFIX}/
NPM_PATH="lib/node_modules/npm/bin/npm-cli.js" NPM_PATH="lib/node_modules/npm/bin/npm-cli.js"
else else
@ -60,7 +60,7 @@ function build {
echo "Unsupported RUN_DRIVER ${RUN_DRIVER}" echo "Unsupported RUN_DRIVER ${RUN_DRIVER}"
exit 1 exit 1
fi fi
zip -r ../playwright-${PACKAGE_VERSION}-${SUFFIX}.zip . zip -q -r ../playwright-${PACKAGE_VERSION}-${SUFFIX}.zip .
} }
build "node-v12.20.1-darwin-x64" "mac" "tar.gz" "run-driver-posix.sh" build "node-v12.20.1-darwin-x64" "mac" "tar.gz" "run-driver-posix.sh"