Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix: allow setting input files for detached <input> elements (#5467)

Browse source 
Fixes #5403
This commit is contained in:
Andrey Lushnikov 2021-02-16 10:22:46 -08:00 committed by GitHub
parent 4f1d84d6b9
commit 6b40d75d03
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/server/dom.ts
View file

@ -529,8 +529,6 @@ export class ElementHandle<T extends Node = Node> extends js.JSHandle<T> {
const multiple = throwFatalDOMError(await this._evaluateInUtility(([injected, node]): 'error:notinput' | 'error:notconnected' | boolean => { const multiple = throwFatalDOMError(await this._evaluateInUtility(([injected, node]): 'error:notinput' | 'error:notconnected' | boolean => {
if (node.nodeType !== Node.ELEMENT_NODE || (node as Node as Element).tagName !== 'INPUT') if (node.nodeType !== Node.ELEMENT_NODE || (node as Node as Element).tagName !== 'INPUT')
return 'error:notinput'; return 'error:notinput';
if (!node.isConnected)
return 'error:notconnected';
const input = node as Node as HTMLInputElement; const input = node as Node as HTMLInputElement;
return input.multiple; return input.multiple;
}, {})); }, {}));

13
test/page-set-input-files.spec.ts
View file

@ -104,15 +104,20 @@ it('should work when file input is attached to DOM', async ({page, server}) => {
}); });
it('should work when file input is not attached to DOM', async ({page, server}) => { it('should work when file input is not attached to DOM', async ({page, server}) => {
const [chooser] = await Promise.all([ const [,content] = await Promise.all([
page.waitForEvent('filechooser'), page.waitForEvent('filechooser').then(chooser => chooser.setFiles(FILE_TO_UPLOAD)),
page.evaluate(() => { page.evaluate(async () => {
const el = document.createElement('input'); const el = document.createElement('input');
el.type = 'file'; el.type = 'file';
el.click(); el.click();
await new Promise(x => el.oninput = x);
const reader = new FileReader();
const promise = new Promise(fulfill => reader.onload = fulfill);
reader.readAsText(el.files[0]);
return promise.then(() => reader.result);
}), }),
]); ]);
expect(chooser).toBeTruthy(); expect(content).toBe('contents of the file');
}); });
it('should not throw when filechooser belongs to iframe', (test, { browserName }) => { it('should not throw when filechooser belongs to iframe', (test, { browserName }) => {