Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(webkit): pass popup tests (#1138)

Browse source
This commit is contained in:
Yury Semikhatsky 2020-02-27 08:43:01 -08:00 committed by GitHub
parent d41342f3e0
commit 6b6a671754
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
package.json
View file

@ -10,7 +10,7 @@
"playwright": { "playwright": {
"chromium_revision": "744254", "chromium_revision": "744254",
"firefox_revision": "1031", "firefox_revision": "1031",
"webkit_revision": "1159" "webkit_revision": "1162"
}, },
"scripts": { "scripts": {
"ctest": "cross-env BROWSER=chromium node test/test.js", "ctest": "cross-env BROWSER=chromium node test/test.js",

6
test/popup.spec.js
View file

@ -20,7 +20,7 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE
const {beforeAll, beforeEach, afterAll, afterEach} = testRunner; const {beforeAll, beforeEach, afterAll, afterEach} = testRunner;
describe('window.open', function() { describe('window.open', function() {
it.skip(CHROMIUM || WEBKIT)('should inherit user agent from browser context', async function({browser, server}) { it.skip(CHROMIUM)('should inherit user agent from browser context', async function({browser, server}) {
const context = await browser.newContext({ const context = await browser.newContext({
userAgent: 'hey' userAgent: 'hey'
}); });
@ -61,9 +61,9 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE
await context.close(); await context.close();
expect(hasTouch).toBe(true); expect(hasTouch).toBe(true);
}); });
it.skip(CHROMIUM || WEBKIT)('should inherit viewport size from browser context', async function({browser, server}) { it.skip(CHROMIUM)('should inherit viewport size from browser context', async function({browser, server}) {
const context = await browser.newContext({ const context = await browser.newContext({
viewport: { width: 400, height: 500, isMobile: true } viewport: { width: 400, height: 500 }
}); });
const page = await context.newPage(); const page = await context.newPage();
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);