Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

browser(firefox): browser.version() to return full version (#4491)

Browse source 
Currently, browser.version() returns `83.0`, whereas launching firefox
with `--version` flag returns `83.0b3`. This patch alings protocol's
`Browser.version()` with flag output.
This commit is contained in:
Andrey Lushnikov 2020-11-19 08:24:17 -08:00 committed by GitHub
parent 1169c5ab50
commit 6bc45d9247
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
browser_patches/firefox/BUILD_NUMBER
View file

@ -1,2 +1,2 @@
1211 1212
Changed: lushnikov@chromium.org Wed 18 Nov 2020 08:00:56 AM PST Changed: lushnikov@chromium.org Thu 19 Nov 2020 08:08:27 AM PST

5
browser_patches/firefox/juggler/protocol/BrowserHandler.js
View file

@ -9,6 +9,7 @@ const {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
const {TargetRegistry} = ChromeUtils.import("chrome://juggler/content/TargetRegistry.js"); const {TargetRegistry} = ChromeUtils.import("chrome://juggler/content/TargetRegistry.js");
const {Helper} = ChromeUtils.import('chrome://juggler/content/Helper.js'); const {Helper} = ChromeUtils.import('chrome://juggler/content/Helper.js');
const {PageHandler} = ChromeUtils.import("chrome://juggler/content/protocol/PageHandler.js"); const {PageHandler} = ChromeUtils.import("chrome://juggler/content/protocol/PageHandler.js");
const {AppConstants} = ChromeUtils.import("resource://gre/modules/AppConstants.jsm");
const helper = new Helper(); const helper = new Helper();
@ -252,9 +253,7 @@ class BrowserHandler {
} }
async ['Browser.getInfo']() { async ['Browser.getInfo']() {
const version = Components.classes["@mozilla.org/xre/app-info;1"] const version = AppConstants.MOZ_APP_VERSION_DISPLAY;
.getService(Components.interfaces.nsIXULAppInfo)
.version;
const userAgent = Components.classes["@mozilla.org/network/protocol;1?name=http"] const userAgent = Components.classes["@mozilla.org/network/protocol;1?name=http"]
.getService(Components.interfaces.nsIHttpProtocolHandler) .getService(Components.interfaces.nsIHttpProtocolHandler)
.userAgent; .userAgent;