diff --git a/packages/playwright-core/src/server/debugController.ts b/packages/playwright-core/src/server/debugController.ts index 53c6c3d99e..a9a79a49e2 100644 --- a/packages/playwright-core/src/server/debugController.ts +++ b/packages/playwright-core/src/server/debugController.ts @@ -14,7 +14,7 @@ * limitations under the License. */ -import type { Mode, Source } from '@recorder/recorderTypes'; +import type { ElementInfo, Mode, Source } from '@recorder/recorderTypes'; import { gracefullyProcessExitDoNotHang } from '../utils/processLauncher'; import type { Browser } from './browser'; import type { BrowserContext } from './browserContext'; @@ -221,9 +221,9 @@ class InspectingRecorderApp extends EmptyRecorderApp { this._debugController = debugController; } - override async setSelector(selector: string): Promise { - const locator: string = asLocator(this._debugController._sdkLanguage, selector); - this._debugController.emit(DebugController.Events.InspectRequested, { selector, locator }); + override async elementPicked(elementInfo: ElementInfo): Promise { + const locator: string = asLocator(this._debugController._sdkLanguage, elementInfo.selector); + this._debugController.emit(DebugController.Events.InspectRequested, { selector: elementInfo.selector, locator }); } override async setSources(sources: Source[]): Promise { diff --git a/packages/playwright-core/src/server/injected/ariaSnapshot.ts b/packages/playwright-core/src/server/injected/ariaSnapshot.ts index 682f48365a..7156d0cce7 100644 --- a/packages/playwright-core/src/server/injected/ariaSnapshot.ts +++ b/packages/playwright-core/src/server/injected/ariaSnapshot.ts @@ -53,7 +53,7 @@ export function generateAriaTree(rootElement: Element): AriaNode { return; const element = node as Element; - if (roleUtils.isElementIgnoredForAria(element)) + if (roleUtils.isElementHiddenForAria(element)) return; const visible = isElementVisible(element); @@ -281,7 +281,7 @@ export function renderAriaTree(ariaNode: AriaNode, options?: { noText?: boolean const visit = (ariaNode: AriaNode | string, indent: string) => { if (typeof ariaNode === 'string') { if (!options?.noText) - lines.push(indent + '- text: ' + escapeYamlString(ariaNode)); + lines.push(indent + '- text: ' + quoteYamlString(ariaNode)); return; } let line = `${indent}- ${ariaNode.role}`; @@ -308,7 +308,7 @@ export function renderAriaTree(ariaNode: AriaNode, options?: { noText?: boolean const stringValue = !ariaNode.children.length || (ariaNode.children?.length === 1 && typeof ariaNode.children[0] === 'string'); if (stringValue) { if (!options?.noText && ariaNode.children.length) - line += ': ' + escapeYamlString(ariaNode.children?.[0] as string); + line += ': ' + quoteYamlString(ariaNode.children?.[0] as string); lines.push(line); return; } @@ -328,36 +328,10 @@ export function renderAriaTree(ariaNode: AriaNode, options?: { noText?: boolean return lines.join('\n'); } -function escapeYamlString(str: string) { - if (str === '') - return '""'; - - const needQuotes = ( - // Starts or ends with whitespace - /^\s|\s$/.test(str) || - // Contains control characters - /[\x00-\x1f]/.test(str) || - // Contains special YAML characters that could cause parsing issues - /[\[\]{}&*!,|>%@`]/.test(str) || - // Contains a colon followed by a space (could be interpreted as a key-value pair) - /:\s/.test(str) || - // Is a YAML boolean or null value - /^(?:y|Y|yes|Yes|YES|n|N|no|No|NO|true|True|TRUE|false|False|FALSE|null|Null|NULL|~)$/.test(str) || - // Could be interpreted as a number - /^[-+]?[0-9]*\.?[0-9]+([eE][-+]?[0-9]+)?$/.test(str) || - // Contains a newline character - /\n/.test(str) || - // Starts with a special character - /^[\-?:,>|%@"`]/.test(str) - ); - - if (needQuotes) { - return `"${str - .replace(/\\/g, '\\\\') - .replace(/"/g, '\\"') - .replace(/\n/g, '\\n') - .replace(/\r/g, '\\r')}"`; - } - - return str; +function quoteYamlString(str: string) { + return `"${str + .replace(/\\/g, '\\\\') + .replace(/"/g, '\\"') + .replace(/\n/g, '\\n') + .replace(/\r/g, '\\r')}"`; } diff --git a/packages/playwright-core/src/server/injected/consoleApi.ts b/packages/playwright-core/src/server/injected/consoleApi.ts index 0287240493..eae874834e 100644 --- a/packages/playwright-core/src/server/injected/consoleApi.ts +++ b/packages/playwright-core/src/server/injected/consoleApi.ts @@ -85,7 +85,11 @@ class ConsoleAPI { inspect: (selector: string) => this._inspect(selector), selector: (element: Element) => this._selector(element), generateLocator: (element: Element, language?: Language) => this._generateLocator(element, language), - ariaSnapshot: (element?: Element) => this._injectedScript.ariaSnapshot(element || this._injectedScript.document.body), + ariaSnapshot: (element?: Element) => { + const snapshot = this._injectedScript.ariaSnapshot(element || this._injectedScript.document.body); + // eslint-disable-next-line no-console + console.log(snapshot); + }, resume: () => this._resume(), ...new Locator(injectedScript, ''), }; diff --git a/packages/playwright-core/src/server/injected/recorder/pollingRecorder.ts b/packages/playwright-core/src/server/injected/recorder/pollingRecorder.ts index 9a96d8f25d..c48645ad09 100644 --- a/packages/playwright-core/src/server/injected/recorder/pollingRecorder.ts +++ b/packages/playwright-core/src/server/injected/recorder/pollingRecorder.ts @@ -14,7 +14,7 @@ * limitations under the License. */ -import type { Mode, OverlayState, UIState } from '@recorder/recorderTypes'; +import type { ElementInfo, Mode, OverlayState, UIState } from '@recorder/recorderTypes'; import type * as actions from '@recorder/actions'; import type { InjectedScript } from '../injectedScript'; import { Recorder } from './recorder'; @@ -24,7 +24,7 @@ interface Embedder { __pw_recorderPerformAction(action: actions.PerformOnRecordAction): Promise; __pw_recorderRecordAction(action: actions.Action): Promise; __pw_recorderState(): Promise; - __pw_recorderSetSelector(selector: string): Promise; + __pw_recorderElementPicked(element: { selector: string, ariaSnapshot?: string }): Promise; __pw_recorderSetMode(mode: Mode): Promise; __pw_recorderSetOverlayState(state: OverlayState): Promise; __pw_refreshOverlay(): void; @@ -75,8 +75,8 @@ export class PollingRecorder implements RecorderDelegate { await this._embedder.__pw_recorderRecordAction(action); } - async setSelector(selector: string): Promise { - await this._embedder.__pw_recorderSetSelector(selector); + async elementPicked(elementInfo: ElementInfo): Promise { + await this._embedder.__pw_recorderElementPicked(elementInfo); } async setMode(mode: Mode): Promise { diff --git a/packages/playwright-core/src/server/injected/recorder/recorder.ts b/packages/playwright-core/src/server/injected/recorder/recorder.ts index 7c38c6386e..9dfa2cd372 100644 --- a/packages/playwright-core/src/server/injected/recorder/recorder.ts +++ b/packages/playwright-core/src/server/injected/recorder/recorder.ts @@ -17,7 +17,7 @@ import type * as actions from '@recorder/actions'; import type { InjectedScript } from '../injectedScript'; import type { Point } from '../../../common/types'; -import type { Mode, OverlayState, UIState } from '@recorder/recorderTypes'; +import type { ElementInfo, Mode, OverlayState, UIState } from '@recorder/recorderTypes'; import type { ElementText } from '../selectorUtils'; import type { Highlight, HighlightOptions } from '../highlight'; import clipPaths from './clipPaths'; @@ -25,7 +25,7 @@ import clipPaths from './clipPaths'; export interface RecorderDelegate { performAction?(action: actions.PerformOnRecordAction): Promise; recordAction?(action: actions.Action): Promise; - setSelector?(selector: string): Promise; + elementPicked?(elementInfo: ElementInfo): Promise; setMode?(mode: Mode): Promise; setOverlayState?(state: OverlayState): Promise; highlightUpdated?(): void; @@ -85,7 +85,7 @@ class InspectTool implements RecorderTool { if (event.button !== 0) return; if (this._hoveredModel?.selector) - this._commit(this._hoveredModel.selector); + this._commit(this._hoveredModel.selector, this._hoveredModel); } onContextMenu(event: MouseEvent) { @@ -93,13 +93,14 @@ class InspectTool implements RecorderTool { && this._hoveredSelectors && this._hoveredSelectors.length > 1) { consumeEvent(event); const selectors = this._hoveredSelectors; + const hoveredModel = this._hoveredModel; this._hoveredModel.tooltipFooter = undefined; this._hoveredModel.tooltipList = selectors.map(selector => this._recorder.injectedScript.utils.asLocator(this._recorder.state.language, selector)); this._hoveredModel.tooltipListItemSelected = (index: number | undefined) => { if (index === undefined) this._reset(true); else - this._commit(selectors[index]); + this._commit(selectors[index], hoveredModel); }; this._recorder.updateHighlight(this._hoveredModel, true); } @@ -181,7 +182,7 @@ class InspectTool implements RecorderTool { this._reset(false); } - private _commit(selector: string) { + private _commit(selector: string, model: HighlightModel) { if (this._assertVisibility) { this._recorder.recordAction({ name: 'assertVisible', @@ -191,7 +192,7 @@ class InspectTool implements RecorderTool { this._recorder.setMode('recording'); this._recorder.overlay?.flashToolSucceeded('assertingVisibility'); } else { - this._recorder.setSelector(selector); + this._recorder.elementPicked(selector, model); } } @@ -1314,8 +1315,9 @@ export class Recorder { void this._delegate.setOverlayState?.(state); } - setSelector(selector: string) { - void this._delegate.setSelector?.(selector); + elementPicked(selector: string, model: HighlightModel) { + const ariaSnapshot = this.injectedScript.ariaSnapshot(model.elements[0]); + void this._delegate.elementPicked?.({ selector, ariaSnapshot }); } } diff --git a/packages/playwright-core/src/server/recorder.ts b/packages/playwright-core/src/server/recorder.ts index c5e133c069..74ebefee86 100644 --- a/packages/playwright-core/src/server/recorder.ts +++ b/packages/playwright-core/src/server/recorder.ts @@ -15,7 +15,7 @@ */ import type * as channels from '@protocol/channels'; -import type { CallLog, CallLogStatus, EventData, Mode, OverlayState, Source, UIState } from '@recorder/recorderTypes'; +import type { CallLog, CallLogStatus, ElementInfo, EventData, Mode, OverlayState, Source, UIState } from '@recorder/recorderTypes'; import * as fs from 'fs'; import type { Point } from '../common/types'; import * as consoleApiSource from '../generated/consoleApiSource'; @@ -168,9 +168,9 @@ export class Recorder implements InstrumentationListener, IRecorder { return uiState; }); - await this._context.exposeBinding('__pw_recorderSetSelector', false, async ({ frame }, selector: string) => { + await this._context.exposeBinding('__pw_recorderElementPicked', false, async ({ frame }, elementInfo: ElementInfo) => { const selectorChain = await generateFrameSelector(frame); - await this._recorderApp?.setSelector(buildFullSelector(selectorChain, selector), true); + await this._recorderApp?.elementPicked({ selector: buildFullSelector(selectorChain, elementInfo.selector), ariaSnapshot: elementInfo.ariaSnapshot }, true); }); await this._context.exposeBinding('__pw_recorderSetMode', false, async ({ frame }, mode: Mode) => { @@ -256,12 +256,10 @@ export class Recorder implements InstrumentationListener, IRecorder { this._currentCallsMetadata.set(metadata, sdkObject); this._updateUserSources(); this.updateCallLog([metadata]); - if (isScreenshotCommand(metadata)) { + if (isScreenshotCommand(metadata)) this.hideHighlightedSelector(); - } else if (metadata.params && metadata.params.selector) { + else if (metadata.params && metadata.params.selector) this._highlightedSelector = metadata.params.selector; - this._recorderApp?.setSelector(this._highlightedSelector).catch(() => {}); - } } async onAfterCall(sdkObject: SdkObject, metadata: CallMetadata) { diff --git a/packages/playwright-core/src/server/recorder/recorderApp.ts b/packages/playwright-core/src/server/recorder/recorderApp.ts index 3f9a636579..df27a96c6c 100644 --- a/packages/playwright-core/src/server/recorder/recorderApp.ts +++ b/packages/playwright-core/src/server/recorder/recorderApp.ts @@ -20,7 +20,7 @@ import type { Page } from '../page'; import { ProgressController } from '../progress'; import { EventEmitter } from 'events'; import { serverSideCallMetadata } from '../instrumentation'; -import type { CallLog, Mode, Source } from '@recorder/recorderTypes'; +import type { CallLog, ElementInfo, Mode, Source } from '@recorder/recorderTypes'; import { isUnderTest } from '../../utils'; import { mime } from '../../utilsBundle'; import { syncLocalStorageWithSettings } from '../launchApp'; @@ -35,7 +35,7 @@ export class EmptyRecorderApp extends EventEmitter implements IRecorderApp { async setPaused(paused: boolean): Promise {} async setMode(mode: Mode): Promise {} async setRunningFile(file: string | undefined): Promise {} - async setSelector(selector: string, userGesture?: boolean): Promise {} + async elementPicked(elementInfo: ElementInfo, userGesture?: boolean): Promise {} async updateCallLogs(callLogs: CallLog[]): Promise {} async setSources(sources: Source[]): Promise {} async setActions(actions: actions.ActionInContext[], sources: Source[]): Promise {} @@ -158,18 +158,12 @@ export class RecorderApp extends EventEmitter implements IRecorderApp { async setActions(actions: actions.ActionInContext[], sources: Source[]): Promise { } - async setSelector(selector: string, userGesture?: boolean): Promise { - if (userGesture) { - if (this._recorder?.mode() === 'inspecting') { - this._recorder.setMode('standby'); - this._page.bringToFront(); - } else { - this._recorder?.setMode('recording'); - } - } - await this._page.mainFrame().evaluateExpression(((data: { selector: string, userGesture?: boolean }) => { - window.playwrightSetSelector(data.selector, data.userGesture); - }).toString(), { isFunction: true }, { selector, userGesture }).catch(() => {}); + async elementPicked(elementInfo: ElementInfo, userGesture?: boolean): Promise { + if (userGesture) + this._page.bringToFront(); + await this._page.mainFrame().evaluateExpression(((param: { elementInfo: ElementInfo, userGesture?: boolean }) => { + window.playwrightElementPicked(param.elementInfo, param.userGesture); + }).toString(), { isFunction: true }, { elementInfo, userGesture }).catch(() => {}); } async updateCallLogs(callLogs: CallLog[]): Promise { diff --git a/packages/playwright-core/src/server/recorder/recorderFrontend.ts b/packages/playwright-core/src/server/recorder/recorderFrontend.ts index 9bf48022a7..dbba78ceeb 100644 --- a/packages/playwright-core/src/server/recorder/recorderFrontend.ts +++ b/packages/playwright-core/src/server/recorder/recorderFrontend.ts @@ -15,7 +15,7 @@ */ import type * as actions from '@recorder/actions'; -import type { CallLog, Mode, Source } from '@recorder/recorderTypes'; +import type { CallLog, Mode, Source, ElementInfo } from '@recorder/recorderTypes'; import type { EventEmitter } from 'events'; export interface IRecorder { @@ -29,7 +29,7 @@ export interface IRecorderApp extends EventEmitter { setPaused(paused: boolean): Promise; setMode(mode: Mode): Promise; setRunningFile(file: string | undefined): Promise; - setSelector(selector: string, userGesture?: boolean): Promise; + elementPicked(elementInfo: ElementInfo, userGesture?: boolean): Promise; updateCallLogs(callLogs: CallLog[]): Promise; setSources(sources: Source[]): Promise; setActions(actions: actions.ActionInContext[], sources: Source[]): Promise; diff --git a/packages/playwright-core/src/server/recorder/recorderInTraceViewer.ts b/packages/playwright-core/src/server/recorder/recorderInTraceViewer.ts index e11ef1283a..fcfd0a36c5 100644 --- a/packages/playwright-core/src/server/recorder/recorderInTraceViewer.ts +++ b/packages/playwright-core/src/server/recorder/recorderInTraceViewer.ts @@ -15,7 +15,7 @@ */ import path from 'path'; -import type { CallLog, Mode, Source } from '@recorder/recorderTypes'; +import type { CallLog, ElementInfo, Mode, Source } from '@recorder/recorderTypes'; import { EventEmitter } from 'events'; import type { IRecorder, IRecorderApp, IRecorderAppFactory } from './recorderFrontend'; import { installRootRedirect, openTraceViewerApp, startTraceViewerServer } from '../trace/viewer/traceViewer'; @@ -70,8 +70,8 @@ export class RecorderInTraceViewer extends EventEmitter implements IRecorderApp this._transport.deliverEvent('setRunningFile', { file }); } - async setSelector(selector: string, userGesture?: boolean): Promise { - this._transport.deliverEvent('setSelector', { selector, userGesture }); + async elementPicked(elementInfo: ElementInfo, userGesture?: boolean): Promise { + this._transport.deliverEvent('elementPicked', { elementInfo, userGesture }); } async updateCallLogs(callLogs: CallLog[]): Promise { diff --git a/packages/recorder/src/recorder.tsx b/packages/recorder/src/recorder.tsx index a8cd2b2719..2e05b65f6e 100644 --- a/packages/recorder/src/recorder.tsx +++ b/packages/recorder/src/recorder.tsx @@ -14,7 +14,7 @@ limitations under the License. */ -import type { CallLog, Mode, Source } from './recorderTypes'; +import type { CallLog, ElementInfo, Mode, Source } from './recorderTypes'; import { CodeMirrorWrapper } from '@web/components/codeMirrorWrapper'; import { SplitView } from '@web/components/splitView'; import { TabbedPane } from '@web/components/tabbedPane'; @@ -44,6 +44,7 @@ export const Recorder: React.FC = ({ const [selectedFileId, setSelectedFileId] = React.useState(); const [runningFileId, setRunningFileId] = React.useState(); const [selectedTab, setSelectedTab] = React.useState('log'); + const [ariaSnapshot, setAriaSnapshot] = React.useState(); const fileId = selectedFileId || runningFileId || sources[0]?.id; @@ -57,11 +58,18 @@ export const Recorder: React.FC = ({ }, [sources, fileId]); const [locator, setLocator] = React.useState(''); - window.playwrightSetSelector = (selector: string, focus?: boolean) => { + window.playwrightElementPicked = (elementInfo: ElementInfo, userGesture?: boolean) => { const language = source.language; - if (focus) + setLocator(asLocator(language, elementInfo.selector)); + setAriaSnapshot(elementInfo.ariaSnapshot); + if (userGesture && selectedTab !== 'locator' && selectedTab !== 'aria') setSelectedTab('locator'); - setLocator(asLocator(language, selector)); + + if (mode === 'inspecting' && selectedTab === 'aria') { + // Keep exploring aria. + } else { + window.dispatch({ event: 'setMode', params: { mode: mode === 'inspecting' ? 'standby' : 'recording' } }).catch(() => { }); + } }; window.playwrightSetRunningFile = setRunningFileId; @@ -94,7 +102,7 @@ export const Recorder: React.FC = ({ }, [paused]); const onEditorChange = React.useCallback((selector: string) => { - if (mode === 'none') + if (mode === 'none' || mode === 'inspecting') window.dispatch({ event: 'setMode', params: { mode: 'standby' } }); setLocator(selector); window.dispatch({ event: 'selectorUpdated', params: { selector } }); @@ -157,7 +165,7 @@ export const Recorder: React.FC = ({ sidebarSize={200} main={} sidebar={ copy(locator)} />] : []} + rightToolbar={selectedTab === 'locator' || selectedTab === 'aria' ? [ copy((selectedTab === 'locator' ? locator : ariaSnapshot) || '')} />] : []} tabs={[ { id: 'locator', @@ -169,6 +177,11 @@ export const Recorder: React.FC = ({ title: 'Log', render: () => }, + { + id: 'aria', + title: 'Accessibility', + render: () => + }, ]} selectedTab={selectedTab} setSelectedTab={setSelectedTab} diff --git a/packages/recorder/src/recorderTypes.ts b/packages/recorder/src/recorderTypes.ts index a0e04a7283..22afde3dad 100644 --- a/packages/recorder/src/recorderTypes.ts +++ b/packages/recorder/src/recorderTypes.ts @@ -29,6 +29,11 @@ export type Mode = | 'assertingValue' | 'assertingSnapshot'; +export type ElementInfo = { + selector: string; + ariaSnapshot: string; +}; + export type EventData = { event: | 'clear' @@ -98,7 +103,7 @@ declare global { playwrightSetOverlayVisible: (visible: boolean) => void; playwrightUpdateLogs: (callLogs: CallLog[]) => void; playwrightSetRunningFile: (file: string | undefined) => void; - playwrightSetSelector: (selector: string, focus?: boolean) => void; + playwrightElementPicked: (elementInfo: ElementInfo, userGesture?: boolean) => void; playwrightSourcesEchoForTest: Source[]; dispatch(data: any): Promise; } diff --git a/packages/recorder/tsconfig.json b/packages/recorder/tsconfig.json index 10f4bfcf2f..16546d6e0d 100644 --- a/packages/recorder/tsconfig.json +++ b/packages/recorder/tsconfig.json @@ -19,6 +19,7 @@ "paths": { "@isomorphic/*": ["../playwright-core/src/utils/isomorphic/*"], "@protocol/*": ["../protocol/src/*"], + "@recorder/*": ["../recorder/src/*"], "@web/*": ["../web/src/*"], } }, diff --git a/packages/trace-viewer/src/ui/snapshotTab.tsx b/packages/trace-viewer/src/ui/snapshotTab.tsx index f8bcc3a5a3..fb874ccef4 100644 --- a/packages/trace-viewer/src/ui/snapshotTab.tsx +++ b/packages/trace-viewer/src/ui/snapshotTab.tsx @@ -30,6 +30,7 @@ import { locatorOrSelectorAsSelector } from '@isomorphic/locatorParser'; import { TabbedPaneTab } from '@web/components/tabbedPane'; import { BrowserFrame } from './browserFrame'; import { ClickPointer } from './clickPointer'; +import type { ElementInfo } from '@recorder/recorderTypes'; function findClosest(items: T[], metric: (v: T) => number, target: number) { return items.find((item, index) => { @@ -291,8 +292,8 @@ export const InspectModeController: React.FunctionComponent<{ testIdAttributeName, overlay: { offsetX: 0 }, }, { - async setSelector(selector: string) { - setHighlightedLocator(asLocator(sdkLanguage, frameSelector + selector)); + async elementPicked(elementInfo: ElementInfo) { + setHighlightedLocator(asLocator(sdkLanguage, frameSelector + elementInfo.selector)); }, highlightUpdated() { for (const r of recorders) { diff --git a/packages/web/src/components/codeMirrorModule.tsx b/packages/web/src/components/codeMirrorModule.tsx index 4376e0a18f..ea0953bf8f 100644 --- a/packages/web/src/components/codeMirrorModule.tsx +++ b/packages/web/src/components/codeMirrorModule.tsx @@ -25,6 +25,7 @@ import 'codemirror-shadow-1/mode/python/python'; import 'codemirror-shadow-1/mode/clike/clike'; import 'codemirror-shadow-1/mode/markdown/markdown'; import 'codemirror-shadow-1/addon/mode/simple'; +import 'codemirror-shadow-1/mode/yaml/yaml'; export type CodeMirror = typeof codemirrorType; export default codemirror; diff --git a/tests/page/page-aria-snapshot.spec.ts b/tests/page/page-aria-snapshot.spec.ts index 88306a1e43..188808a178 100644 --- a/tests/page/page-aria-snapshot.spec.ts +++ b/tests/page/page-aria-snapshot.spec.ts @@ -64,8 +64,8 @@ it('should snapshot list with accessible name', async ({ page }) => { `); await checkAndMatchSnapshot(page.locator('body'), ` - list "my list": - - listitem: one - - listitem: two + - listitem: "one" + - listitem: "two" `); }); @@ -92,7 +92,7 @@ it('should allow text nodes', async ({ page }) => { await checkAndMatchSnapshot(page.locator('body'), ` - heading "Microsoft" [level=1] - - text: Open source projects and samples from Microsoft + - text: "Open source projects and samples from Microsoft" `); }); @@ -105,7 +105,7 @@ it('should snapshot details visibility', async ({ page }) => { `); await checkAndMatchSnapshot(page.locator('body'), ` - - group: Summary + - group: "Summary" `); }); @@ -145,10 +145,10 @@ it('should snapshot integration', async ({ page }) => { await checkAndMatchSnapshot(page.locator('body'), ` - heading "Microsoft" [level=1] - - text: Open source projects and samples from Microsoft + - text: "Open source projects and samples from Microsoft" - list: - listitem: - - group: Verified + - group: "Verified" - listitem: - link "Sponsor" `); @@ -164,7 +164,7 @@ it('should support multiline text', async ({ page }) => { `); await checkAndMatchSnapshot(page.locator('body'), ` - - paragraph: Line 1 Line 2 Line 3 + - paragraph: "Line 1 Line 2 Line 3" `); await expect(page.locator('body')).toMatchAriaSnapshot(` - paragraph: | @@ -180,7 +180,7 @@ it('should concatenate span text', async ({ page }) => { `); await checkAndMatchSnapshot(page.locator('body'), ` - - text: One Two Three + - text: "One Two Three" `); }); @@ -190,7 +190,7 @@ it('should concatenate span text 2', async ({ page }) => { `); await checkAndMatchSnapshot(page.locator('body'), ` - - text: One Two Three + - text: "One Two Three" `); }); @@ -200,7 +200,7 @@ it('should concatenate div text with spaces', async ({ page }) => { `); await checkAndMatchSnapshot(page.locator('body'), ` - - text: One Two Three + - text: "One Two Three" `); }); @@ -362,12 +362,12 @@ it('should snapshot inner text', async ({ page }) => { await checkAndMatchSnapshot(page.locator('body'), ` - listitem: - - text: a.test.ts + - text: "a.test.ts" - button "Run" - button "Show source" - button "Watch" - listitem: - - text: snapshot 30ms + - text: "snapshot 30ms" - button "Run" - button "Show source" - button "Watch" @@ -382,6 +382,6 @@ it('should include pseudo codepoints', async ({ page, server }) => { `); await checkAndMatchSnapshot(page.locator('body'), ` - - paragraph: \ueab2hello + - paragraph: "\ueab2hello" `); }); diff --git a/utils/build/build.js b/utils/build/build.js index 56442c0948..7a289bd5ed 100644 --- a/utils/build/build.js +++ b/utils/build/build.js @@ -283,7 +283,7 @@ for (const webPackage of ['html-reporter', 'recorder', 'trace-viewer']) { 'vite', 'build', ...(watchMode ? ['--watch', '--minify=false'] : []), - ...(withSourceMaps ? ['--sourcemap'] : []), + ...(withSourceMaps ? ['--sourcemap=inline'] : []), ], shell: true, cwd: path.join(__dirname, '..', '..', 'packages', webPackage), @@ -299,7 +299,7 @@ steps.push({ 'vite.sw.config.ts', 'build', ...(watchMode ? ['--watch', '--minify=false'] : []), - ...(withSourceMaps ? ['--sourcemap'] : []), + ...(withSourceMaps ? ['--sourcemap=inline'] : []), ], shell: true, cwd: path.join(__dirname, '..', '..', 'packages', 'trace-viewer'),