Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: rebaseline webkit signals.spec (#24471)

Browse source 
Fixes #22226.
This commit is contained in:
Dmitry Gozman 2023-07-27 13:36:43 -07:00 committed by GitHub
parent ad467446bb
commit 6c1723ca3e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
tests/library/signals.spec.ts
View file

@ -60,12 +60,17 @@ test.describe('signals', () => {
test.skip(({ platform }) => platform === 'win32'); test.skip(({ platform }) => platform === 'win32');
test('should report browser close signal 2', async ({ startRemoteServer, server, isMac, browserName }) => { test('should report browser close signal 2', async ({ startRemoteServer, server, isMac, browserName }) => {
test.fixme(isMac && browserName === 'webkit' && parseInt(os.release(), 10) >= 22, 'https://github.com/microsoft/playwright/issues/22226');
const remoteServer = await startRemoteServer('launchServer', { url: server.EMPTY_PAGE }); const remoteServer = await startRemoteServer('launchServer', { url: server.EMPTY_PAGE });
const pid = await remoteServer.out('pid'); const pid = await remoteServer.out('pid');
process.kill(-pid, 'SIGKILL'); process.kill(-pid, 'SIGKILL');
if (isMac && browserName === 'webkit' && parseInt(os.release(), 10) === 22) {
// WebKit on mac13 exits differently.
expect(await remoteServer.out('exitCode')).toBe('137');
expect(await remoteServer.out('signal')).toBe('null');
} else {
expect(await remoteServer.out('exitCode')).toBe('null'); expect(await remoteServer.out('exitCode')).toBe('null');
expect(await remoteServer.out('signal')).toBe('SIGKILL'); expect(await remoteServer.out('signal')).toBe('SIGKILL');
}
process.kill(remoteServer.child().pid); process.kill(remoteServer.child().pid);
await remoteServer.childExitCode(); await remoteServer.childExitCode();
}); });
@ -94,8 +99,7 @@ test.describe('signals', () => {
expect(await remoteServer.childExitCode()).toBe(0); expect(await remoteServer.childExitCode()).toBe(0);
}); });
test('should kill the browser on double SIGINT and remove temp dir', async ({ startRemoteServer, server, isMac, browserName }) => { test('should kill the browser on double SIGINT and remove temp dir', async ({ startRemoteServer, server }) => {
test.fixme(isMac && browserName === 'webkit' && parseInt(os.release(), 10) >= 22, 'https://github.com/microsoft/playwright/issues/22226');
const remoteServer = await startRemoteServer('launchServer', { stallOnClose: true, url: server.EMPTY_PAGE }); const remoteServer = await startRemoteServer('launchServer', { stallOnClose: true, url: server.EMPTY_PAGE });
const tempDir = await remoteServer.out('tempDir'); const tempDir = await remoteServer.out('tempDir');
const before = fs.existsSync(tempDir); const before = fs.existsSync(tempDir);
@ -110,8 +114,7 @@ test.describe('signals', () => {
expect(after).toBe(false); expect(after).toBe(false);
}); });
test('should kill the browser on SIGINT + SIGTERM', async ({ startRemoteServer, server, isMac, browserName }) => { test('should kill the browser on SIGINT + SIGTERM', async ({ startRemoteServer, server }) => {
test.fixme(isMac && browserName === 'webkit' && parseInt(os.release(), 10) >= 22, 'https://github.com/microsoft/playwright/issues/22226');
const remoteServer = await startRemoteServer('launchServer', { stallOnClose: true, url: server.EMPTY_PAGE }); const remoteServer = await startRemoteServer('launchServer', { stallOnClose: true, url: server.EMPTY_PAGE });
process.kill(remoteServer.child().pid, 'SIGINT'); process.kill(remoteServer.child().pid, 'SIGINT');
await remoteServer.out('stalled'); await remoteServer.out('stalled');
@ -121,8 +124,7 @@ test.describe('signals', () => {
expect(await remoteServer.childExitCode()).toBe(0); expect(await remoteServer.childExitCode()).toBe(0);
}); });
test('should kill the browser on SIGTERM + SIGINT', async ({ startRemoteServer, server, isMac, browserName }) => { test('should kill the browser on SIGTERM + SIGINT', async ({ startRemoteServer, server }) => {
test.fixme(isMac && browserName === 'webkit' && parseInt(os.release(), 10) >= 22, 'https://github.com/microsoft/playwright/issues/22226');
const remoteServer = await startRemoteServer('launchServer', { stallOnClose: true, url: server.EMPTY_PAGE }); const remoteServer = await startRemoteServer('launchServer', { stallOnClose: true, url: server.EMPTY_PAGE });
process.kill(remoteServer.child().pid, 'SIGTERM'); process.kill(remoteServer.child().pid, 'SIGTERM');
await remoteServer.out('stalled'); await remoteServer.out('stalled');