From 6c85be4a2f467bbccc6f51d9c8c1187fc87267cf Mon Sep 17 00:00:00 2001 From: Simon Knott Date: Sun, 22 Dec 2024 12:36:21 +0100 Subject: [PATCH] walk back on bash claim --- packages/playwright/src/plugins/webServerPlugin.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/playwright/src/plugins/webServerPlugin.ts b/packages/playwright/src/plugins/webServerPlugin.ts index ac0eb3809d..978ba8b919 100644 --- a/packages/playwright/src/plugins/webServerPlugin.ts +++ b/packages/playwright/src/plugins/webServerPlugin.ts @@ -125,7 +125,7 @@ export class WebServerPlugin implements TestRunnerPlugin { throw new Error('skip graceful shutdown'); // proper usage of SIGINT is to send it to the entire process group, see https://www.cons.org/cracauer/sigint.html - // there's no such convention for SIGTERM, but we follow GNU bash behaviour, which is also sending to the entire process group + // there's no such convention for SIGTERM, so we decide what we want. signaling the process group for consistency. process.kill(-launchedProcess.pid!, signal); return new Promise((resolve, reject) => {