Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: do not open up all TLS sessions when using client-certificates

Browse source
This commit is contained in:
Max Schmitt 2024-08-15 09:26:29 +02:00
parent ef1159e3a3
commit 6de0d10d3e
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
packages/playwright-core/src/server/socksClientCertificatesInterceptor.ts
View file

@ -83,6 +83,7 @@ class SocksProxyConnection {
private _targetCloseEventListener: () => void; private _targetCloseEventListener: () => void;
private _dummyServer: tls.Server | undefined; private _dummyServer: tls.Server | undefined;
private _closed = false; private _closed = false;
private _certTlsOptions: Pick<https.RequestOptions, 'pfx' | 'key' | 'cert'> | undefined;
constructor(socksProxy: ClientCertificatesProxy, uid: string, host: string, port: number) { constructor(socksProxy: ClientCertificatesProxy, uid: string, host: string, port: number) {
this.socksProxy = socksProxy; this.socksProxy = socksProxy;
@ -95,6 +96,7 @@ class SocksProxyConnection {
this.internalTLS?.destroy(); this.internalTLS?.destroy();
this._dummyServer?.close(); this._dummyServer?.close();
}; };
this._certTlsOptions = clientCertificatesToTLSOptions(this.socksProxy.clientCertificates, new URL(`https://${host}:${port}`).origin);
} }
async connect() { async connect() {
@ -126,7 +128,8 @@ class SocksProxyConnection {
if (!this.firstPackageReceived) { if (!this.firstPackageReceived) {
this.firstPackageReceived = true; this.firstPackageReceived = true;
// 0x16 is SSLv3/TLS "handshake" content type: https://en.wikipedia.org/wiki/Transport_Layer_Security#TLS_record // 0x16 is SSLv3/TLS "handshake" content type: https://en.wikipedia.org/wiki/Transport_Layer_Security#TLS_record
if (data[0] === 0x16) // Intercept the session only if the client has provided client certificates for this specific host:port combination.
if (data[0] === 0x16 && this._certTlsOptions)
this._attachTLSListeners(); this._attachTLSListeners();
else else
this.target.on('data', data => this.socksProxy._socksProxy.sendSocketData({ uid: this.uid, data })); this.target.on('data', data => this.socksProxy._socksProxy.sendSocketData({ uid: this.uid, data }));
@ -204,7 +207,7 @@ class SocksProxyConnection {
let secureContext: tls.SecureContext; let secureContext: tls.SecureContext;
try { try {
secureContext = tls.createSecureContext(clientCertificatesToTLSOptions(this.socksProxy.clientCertificates, new URL(`https://${this.host}:${this.port}`).origin)); secureContext = tls.createSecureContext(this._certTlsOptions);
} catch (error) { } catch (error) {
handleError(error); handleError(error);
return; return;