Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix: default list reporter should dump stderr to stderr (#11351)

Browse source 
This is consistent with all other reporters we have in place.
This commit is contained in:
Andrey Lushnikov 2022-01-12 08:43:25 -07:00 committed by GitHub
parent a12e76b52b
commit 6f932fcb4a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
installation-tests/installation-tests.sh
View file

@ -633,7 +633,7 @@ function test_playwright_test_stacks_should_work {
copy_test_scripts copy_test_scripts
echo "Running playwright test" echo "Running playwright test"
OUTPUT=$(DEBUG=pw:api npx playwright test -c . failing.spec.js || true) OUTPUT=$(DEBUG=pw:api npx playwright test -c . failing.spec.js 2>&1 || true)
if [[ "${OUTPUT}" != *"expect.toHaveText started"* ]]; then if [[ "${OUTPUT}" != *"expect.toHaveText started"* ]]; then
echo "ERROR: missing 'expect.toHaveText started' in the output" echo "ERROR: missing 'expect.toHaveText started' in the output"
exit 1 exit 1

2
packages/playwright-test/src/reporters/list.ts
View file

@ -67,7 +67,7 @@ class ListReporter extends BaseReporter {
override onStdErr(chunk: string | Buffer, test?: TestCase, result?: TestResult) { override onStdErr(chunk: string | Buffer, test?: TestCase, result?: TestResult) {
super.onStdErr(chunk, test, result); super.onStdErr(chunk, test, result);
this._dumpToStdio(test, chunk, process.stdout); this._dumpToStdio(test, chunk, process.stderr);
} }
onStepBegin(test: TestCase, result: TestResult, step: TestStep) { onStepBegin(test: TestCase, result: TestResult, step: TestStep) {