Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore(bidi): propertly dispatch ControlRight key event (#34246)

Browse source
This commit is contained in:
Yury Semikhatsky 2025-01-07 16:46:44 -08:00 committed by GitHub
parent 809225503c
commit 6fb6282a9d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 13 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/playwright-core/src/server/bidi/bidiInput.ts
View file

@ -33,7 +33,7 @@ export class RawKeyboardImpl implements input.RawKeyboard {
async keydown(modifiers: Set<types.KeyboardModifier>, code: string, keyCode: number, keyCodeWithoutLocation: number, key: string, location: number, autoRepeat: boolean, text: string | undefined): Promise<void> { async keydown(modifiers: Set<types.KeyboardModifier>, code: string, keyCode: number, keyCodeWithoutLocation: number, key: string, location: number, autoRepeat: boolean, text: string | undefined): Promise<void> {
const actions: bidi.Input.KeySourceAction[] = []; const actions: bidi.Input.KeySourceAction[] = [];
actions.push({ type: 'keyDown', value: getBidiKeyValue(key) }); actions.push({ type: 'keyDown', value: getBidiKeyValue(code) });
// TODO: add modifiers? // TODO: add modifiers?
await this._performActions(actions); await this._performActions(actions);
} }

16
tests/page/page-keyboard.spec.ts
View file

@ -256,16 +256,24 @@ it('should specify location', async ({ page, server }) => {
const textarea = await page.$('textarea'); const textarea = await page.$('textarea');
await textarea.press('Digit5'); await textarea.press('Digit5');
expect(await lastEvent.evaluate(e => e.location)).toBe(0); expect.soft(await lastEvent.evaluate(e => e.location)).toBe(0);
expect.soft(await lastEvent.evaluate(e => e.key)).toBe('5');
expect.soft(await lastEvent.evaluate(e => e.code)).toBe('Digit5');
await textarea.press('ControlLeft'); await textarea.press('ControlLeft');
expect(await lastEvent.evaluate(e => e.location)).toBe(1); expect.soft(await lastEvent.evaluate(e => e.location)).toBe(1);
expect.soft(await lastEvent.evaluate(e => e.key)).toBe('Control');
expect.soft(await lastEvent.evaluate(e => e.code)).toBe('ControlLeft');
await textarea.press('ControlRight'); await textarea.press('ControlRight');
expect(await lastEvent.evaluate(e => e.location)).toBe(2); expect.soft(await lastEvent.evaluate(e => e.location)).toBe(2);
expect.soft(await lastEvent.evaluate(e => e.key)).toBe('Control');
expect.soft(await lastEvent.evaluate(e => e.code)).toBe('ControlRight');
await textarea.press('NumpadSubtract'); await textarea.press('NumpadSubtract');
expect(await lastEvent.evaluate(e => e.location)).toBe(3); expect.soft(await lastEvent.evaluate(e => e.location)).toBe(3);
expect.soft(await lastEvent.evaluate(e => e.key)).toBe('-');
expect.soft(await lastEvent.evaluate(e => e.code)).toBe('NumpadSubtract');
}); });
it('should press Enter', async ({ page, server }) => { it('should press Enter', async ({ page, server }) => {